Add support for more fields to Edge gateway configuration, add multiple subnet support #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Didainius
requested review from
dataclouder,
vbauzys and
lvirbalas
and removed request for
dataclouder and
vbauzys
lvirbalas
reviewed
Nov 19, 2019
CHANGELOG.md
Outdated
| * Change to pointers `DistributedRoutingEnabled` in `GatewayConfiguration` and `DistributedInterface` in `NetworkConfiguration` | ||
| * Change to pointers `DistributedRoutingEnabled` in `GatewayConfiguration` and | ||
| `DistributedInterface` in `NetworkConfiguration` | ||
| * Add new fields to type `GatewayConfiguration`: `FipsModeEnabled` - |
There was a problem hiding this comment.
Says fields in plural, but only a single field is referenced.
| // rules in the old 1.5 format. The new format does not require to use direction in firewall | ||
| // rules. Also, for firewall rules to allow NAT traffic the filter is applied on the original IP | ||
| // addresses. Once set to true cannot be reverted back to false. | ||
| BackwardCompatibilityMode bool `xml:"BackwardCompatibilityMode,omitempty"` |
There was a problem hiding this comment.
Just a note, +1 for this way of adding full docs to fields in types.
vbauzys
approved these changes
Nov 20, 2019
types/v56/types.go
Outdated
| // GatewayBackingConfig defines configuration of the vShield edge VM for this gateway. One of: | ||
| // compact, full. | ||
| GatewayBackingConfig string `xml:"GatewayBackingConfig"` | ||
| // GatewayInterfaces holds configuration for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Note. Test suite passed on 9.5 and 10.