Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APIs for vLCM enablement on a cluster and base ESXi image selection #3377

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

spacegospod
Copy link
Contributor

@spacegospod spacegospod commented Mar 1, 2024

Description

This change is a follow-up to #3368
I am adding a some new methods to the vLCM bindings which allow for

  1. Enabling vCLM on a cluster
  2. Selecting a base ESXi image for the cluster
  3. Retrieving the list of available ESXi images

I also refactored the simulator for the vLCM endpoints

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

Added more test cases to vlcm.bats

Checklist:

  • My code follows the CONTRIBUTION guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

@spacegospod spacegospod self-assigned this Mar 1, 2024
@spacegospod spacegospod requested a review from dougm March 1, 2024 14:10
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @stoyanzhelyazkov

@spacegospod spacegospod force-pushed the feature/cluster-enable-lcm branch from 46c3352 to 7550554 Compare March 5, 2024 10:45
@spacegospod spacegospod merged commit ce4bd63 into vmware:main Mar 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants