Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: toolbox: add freebsd stub for fileExtendedInfoFormat #3629

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

dougm
Copy link
Member

@dougm dougm commented Nov 20, 2024

Fixes #3620

@dougm
Copy link
Member Author

dougm commented Nov 20, 2024

@asxe can you try with these changes? I'm not setup with a freebsd system currently.

@asxe
Copy link

asxe commented Nov 21, 2024

Looks good, TestProcessCommand is skipped. But next TestProcessKill is failing with the same error. Shall it be another PR?

=== RUN TestProcessCommand
process_test.go:86: exec: "/bin/bash": stat /bin/bash: no such file or directory
--- SKIP: TestProcessCommand (0.00s)
=== RUN TestProcessKill
process_test.go:155: exec: "/bin/bash": stat /bin/bash: no such file or directory
--- FAIL: TestProcessKill (0.00s)

@asxe
Copy link

asxe commented Nov 21, 2024

@dougm,
Also, TestProcessIO is failing with 'exec: no command'. Probably, the same /bin/bash dependency.

=== RUN TestProcessIO
process_test.go:250: exec: no command
--- FAIL: TestProcessIO (0.00s)

@asxe
Copy link

asxe commented Nov 21, 2024

all the places where "/bin/bash" hardcoded and not skipped.
Bash is available on FreeBSD as /usr/local/bin/bash if installed.

work/github.com/vmware/[email protected]/guest/toolbox/client.go
work/github.com/vmware/[email protected]/toolbox/process/process_test.go:

@dougm
Copy link
Member Author

dougm commented Dec 5, 2024

Thanks for testing @asxe , let's use this same PR to get all the tests passing on FreeBSD. Updated to just skip the toolbox/process tests unless OS is linux or darwin. Not expecting this package to get used elsewhere anyhow.
Please update if you're able to try the current branch, would like to get tests passing on FreeBSD before the next govmomi release.

Copy link
Member

@akutz akutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dougm !

@dougm dougm merged commit b1027ba into vmware:main Dec 12, 2024
11 checks passed
@dougm dougm deleted the issue-3620 branch December 12, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 'make test' is failing using FreeBSD Ports sysutils/govmomi
3 participants