OVF package enhancements #3640
Merged
OVF package enhancements #3640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akutz
force-pushed
the
feature/ovf-to-configspec
branch
from
52c5643 to
c3b2699
Compare
This patch updates the OVF parser to conform to the DMTF spec
for OVF content. This includes:
* support for VirtualSystemCollection
* a single OperatingSystem section in VirtualSystem
* removing the roll-up sections at the root of the Envelope
that belong only under a VirtualSystem or VirtualSystemCollection
BREAKING: Users of the `ovf` package will need to update their
sources to conform to the changes from this patch. It
should be a fairly simple change.
Signed-off-by: akutz <[email protected]>
This patch adds support to the OVF parser for an enum used to
define the CIM ResourceType.
BREAKING: Users of the `ovf` package may need to cast ResourceType
to a uint16 depending on how they have used the value.
Signed-off-by: akutz <[email protected]>
akutz
force-pushed
the
feature/ovf-to-configspec
branch
3 times, most recently
from
15122e3 to
8a94715
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
akutz
force-pushed
the
feature/ovf-to-configspec
branch
2 times, most recently
from
aab302e to
9800cf9
Compare
akutz
force-pushed
the
feature/ovf-to-configspec
branch
2 times, most recently
from
f7b18ec to
b02268b
Compare
dougm
previously approved these changes
Dec 5, 2024
This patch provides a utility function for transforming an OVF envelop into a ConfigSpec. Signed-off-by: akutz <[email protected]>
akutz
force-pushed
the
feature/ovf-to-configspec
branch
from
b02268b to
495a820
Compare
dougm
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes several enhancements to the
ovfpackage:The OVF parser now conform to the DMTF spec for OVF content. This includes:
ovfpackage will need to update their sources to conform to the changes from this patch. It should be a fairly simple change.The OVF parser now supports an enum used to define the CIM ResourceType.
ovfpackage may need to cast ResourceType to a uint16 depending on how they have used the value.It is now possible to transform an
ovf.Envelopeinto atypes.VirtualMachineConfigSpecCloses: #(issue-number)
How Has This Been Tested?
go test -v -count 1 ./ovfGuidelines
Please read and follow the
CONTRIBUTIONguidelines of this project.