Finder: support automatic Folder recursion #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The mentioned vcsim based tests are in vmware/vic#3908 (commit vmware/vic@051d795) |
This was referenced Feb 11, 2017
dougm
force-pushed
the
rfinder
branch
2 times, most recently
from
f449638 to
d5e2749
Compare
Prior to this change, the Finder behaved like the 'ls' command and as such required a Folder name or wildcard in the path argument to find resources within folders. The original "list" mode of the Finder is maintained, but will now switch to "find" mode if the path argument does not contain a "/". See find/doc.go for details. The public Finder method signatures remain the same, with the exception of ManagedObjectListChildren which now takes an optional (variadic) list of types. No new public methods or types have been added. The 'list.Recurser' type is no longer exported and has moved to an unexported type within the find package. This part of the change assumes that 'list.Recurser' was not used directly outside of the govmomi repo. The tests depend on the Go based vCenter simulator, which currently lives in the vmware/vic repo, but will be moving to the govmomi repo at some point. Fixes vmware#190 Fixes vmware#519 Fixes vmware#540 Closes vmware#507 Closes vmware#593
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the Finder behaved like the 'ls' command and
as such required a Folder name or wildcard in the path argument to
find resources within folders. The original "list" mode of the Finder
is maintained, but will now switch to "find" mode if the path argument
does not contain a "/". See find/doc.go for details.
The public Finder method signatures remain the same, with the exception of
ManagedObjectListChildren which now takes an optional (variadic) list of
types.
No new public methods or types have been added.
The 'list.Recurser' type is no longer exported and has moved to an unexported
type within the find package. This part of the change assumes that 'list.Recurser'
was not used directly outside of the govmomi repo.
The tests depend on the Go based vCenter simulator, which currently lives
in the vmware/vic repo, but will be moving to the govmomi repo at some point.
Fixes #190
Fixes #519
Fixes #540
Closes #507
Closes #593