vdk-core: Adopt 'method' argument in pre-process plugins #3074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of 03dde45, the `pre_ingest_process` and `post_ingest_process` hooks of the IIngesterPlugin were updated to pass the ingest method to user-implemented ingestion plugins. This change updates the IngesterBase to pass the `method` argument from the ingested payloads to the `pre_ingest_process` and `post_ingest_process` hooks of the registered ingester plugins. Testing Done: Updated tests Signed-off-by: Andon Andonov <[email protected]>
antoniivanov
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of 03dde45, the
pre_ingest_processandpost_ingest_processhooks of the IIngesterPlugin were updated to pass the ingest method to user-implemented ingestion plugins.This change updates the IngesterBase to pass the
methodargument from the ingested payloads to thepre_ingest_processandpost_ingest_processhooks of the registered ingester plugins.Testing Done: Updated tests