Rename ovf keys for registry port #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
ghost
requested review from
ghost
changed the title
ghost
mentioned this pull request
zjs
requested changes
Apr 24, 2018
There was a problem hiding this comment.
Does installer/fileserver/server.go also need to be updated?
vic-product/installer/fileserver/server.go
Line 145 in d62d21c
andrewtchin
approved these changes
Apr 24, 2018
zjs
approved these changes
Apr 24, 2018
zjs
pushed a commit
to zjs/vic-product
that referenced
this pull request
Jun 20, 2018
Changes the ovf key names for management_portal.port and registry.port so they do not conflict on the HTML5 client in vSphere 6.7. Fixes vmware#1624.
zjs
pushed a commit
to zjs/vic-product
that referenced
this pull request
Jun 20, 2018
Changes the ovf key names for management_portal.port and registry.port so they do not conflict on the HTML5 client in vSphere 6.7. Fixes vmware#1624. (cherry picked from commit 7c07bfe)
6 tasks
zjs
pushed a commit
to zjs/vic-product
that referenced
this pull request
Jun 22, 2018
Changes the ovf key names for management_portal.port and registry.port so they do not conflict on the HTML5 client in vSphere 6.7. Fixes vmware#1624. (cherry picked from commit 7c07bfe)
zjs
pushed a commit
to zjs/vic-product
that referenced
this pull request
Jun 23, 2018
Changes the ovf key names for management_portal.port and registry.port so they do not conflict on the HTML5 client in vSphere 6.7. Fixes vmware#1624. (cherry picked from commit 7c07bfe)
zjs
pushed a commit
to zjs/vic-product
that referenced
this pull request
Jun 23, 2018
Changes the ovf key names for management_portal.port and registry.port so they do not conflict on the HTML5 client in vSphere 6.7. Fixes vmware#1624. (cherry picked from commit 7c07bfe)
zjs
pushed a commit
that referenced
this pull request
Jun 23, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIC Appliance Checklist:
masterbranchIf this is a feature or change to existing functionality, consider areas of impact with the Impact
Assessment Checklist
Fixes #1624