Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provision vic-ui in the ova #1758

Merged
2 commits merged into from May 18, 2018
Merged

Provision vic-ui in the ova #1758

2 commits merged into from May 18, 2018

Conversation

ghost
Copy link

@ghost ghost commented May 15, 2018

VIC Appliance Checklist:

  • Up to date with master branch
  • Added tests
  • Considered impact to upgrade
  • Tests passing
  • Updated documentation
  • Impact assessment checklist

If this is a feature or change to existing functionality, consider areas of impact with the Impact
Assessment Checklist

Fixes #1433.

  • Downloads vic-ui plugin artifacts as a component of the ova.
  • Updates the fileserver provisioner to package vic-ui with the correct version numbers.
  • Moves the plugin install scripts from vic-ui to vic-product.

@ghost ghost requested a review from zjs May 15, 2018 20:03
@ghost ghost mentioned this pull request May 16, 2018
@mdharamadas1
Copy link
Contributor

@morris-jason Does the tests added here work? If not, we have to make sure they are excluded from nightly runs until they are fixed. It can be done using tag skip.

@ghost
Copy link
Author

ghost commented May 17, 2018

@mdharamadas1 they will not work until #1740 is complete. This pr is to our feature branch, so can we fix the tests during #1701?

@ghost ghost requested a review from mdharamadas1 May 17, 2018 19:51
Copy link
Contributor

@mdharamadas1 mdharamadas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -10,3 +10,4 @@ VIC Integration Test Suite
-
[Group 7 - Upgrade](Group7-Upgrade/TestCases.md)
-
[Group 18 - VIC UI](Group18-VIC-UI/TestCases.md) TODO(morris-jason)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the TODO here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghost ghost merged commit 725da28 into vmware:feature/auto-vic-ui-plugin May 18, 2018
@ghost ghost deleted the 1433/vic-ui-build-updates branch May 18, 2018 19:35
ghost pushed a commit that referenced this pull request Jun 4, 2018
Introduces caching of the vic-ui plugin artifacts as a component
of the ova. Updates the fileserver provisioner to package vic-ui
with the correct version numbers. Fixes #1433.
lmalvins pushed a commit to lmalvins/vic-product that referenced this pull request Jun 5, 2018
Introduces caching of the vic-ui plugin artifacts as a component
of the ova. Updates the fileserver provisioner to package vic-ui
with the correct version numbers. Fixes vmware#1433.
ghost pushed a commit that referenced this pull request Jun 6, 2018
Introduces caching of the vic-ui plugin artifacts as a component
of the ova. Updates the fileserver provisioner to package vic-ui
with the correct version numbers. Fixes #1433.
ghost pushed a commit that referenced this pull request Jun 6, 2018
Introduces caching of the vic-ui plugin artifacts as a component
of the ova. Updates the fileserver provisioner to package vic-ui
with the correct version numbers.

Creates the Fileserver Thumbprint API to return the
thumbprint of a given target ip address or fqdn.
Also refactors the fileserver main process into
main.go, and creates the routes/ and tasks/
sub-packages.

Moves vic-ui plugin dependencies to fileserver. This includes:
 - vic/lib/install/ova
 - vic/lib/install/plugin
- vic/tagvm/
Additionally, refactors ovatools/vic-ui/ui/ui.go to plugin.go that
doesn't include any CLI flags.

Automates the plugin install process and improves
logging in the fileserver:
 - Add trace.Op logging to fileserver tasks
 - Require vcenter thumprint on psc registration
 - Install VIC UI plugins in the initialization process
 - Attaches a managed tag to the Appliance VM
 - Performs a plugin install during the appliance upgrade
   process using the /plugin API.

Fixes #1433, #637, #1720, #1702 and #1789.
wjun pushed a commit to wjun/vic-product that referenced this pull request Aug 20, 2018
…mware#1799)

Introduces caching of the vic-ui plugin artifacts as a component
of the ova. Updates the fileserver provisioner to package vic-ui
with the correct version numbers.

Creates the Fileserver Thumbprint API to return the
thumbprint of a given target ip address or fqdn.
Also refactors the fileserver main process into
main.go, and creates the routes/ and tasks/
sub-packages.

Moves vic-ui plugin dependencies to fileserver. This includes:
 - vic/lib/install/ova
 - vic/lib/install/plugin
- vic/tagvm/
Additionally, refactors ovatools/vic-ui/ui/ui.go to plugin.go that
doesn't include any CLI flags.

Automates the plugin install process and improves
logging in the fileserver:
 - Add trace.Op logging to fileserver tasks
 - Require vcenter thumprint on psc registration
 - Install VIC UI plugins in the initialization process
 - Attaches a managed tag to the Appliance VM
 - Performs a plugin install during the appliance upgrade
   process using the /plugin API.

Fixes vmware#1433, vmware#637, vmware#1720, vmware#1702 and vmware#1789.
wjun pushed a commit to wjun/vic-product that referenced this pull request Aug 22, 2018
…mware#1799)

Introduces caching of the vic-ui plugin artifacts as a component
of the ova. Updates the fileserver provisioner to package vic-ui
with the correct version numbers.

Creates the Fileserver Thumbprint API to return the
thumbprint of a given target ip address or fqdn.
Also refactors the fileserver main process into
main.go, and creates the routes/ and tasks/
sub-packages.

Moves vic-ui plugin dependencies to fileserver. This includes:
 - vic/lib/install/ova
 - vic/lib/install/plugin
- vic/tagvm/
Additionally, refactors ovatools/vic-ui/ui/ui.go to plugin.go that
doesn't include any CLI flags.

Automates the plugin install process and improves
logging in the fileserver:
 - Add trace.Op logging to fileserver tasks
 - Require vcenter thumprint on psc registration
 - Install VIC UI plugins in the initialization process
 - Attaches a managed tag to the Appliance VM
 - Performs a plugin install during the appliance upgrade
   process using the /plugin API.

Fixes vmware#1433, vmware#637, vmware#1720, vmware#1702 and vmware#1789.
zjs pushed a commit that referenced this pull request Aug 23, 2018
Introduces caching of the vic-ui plugin artifacts as a component
of the ova. Updates the fileserver provisioner to package vic-ui
with the correct version numbers.

Creates the Fileserver Thumbprint API to return the
thumbprint of a given target ip address or fqdn.
Also refactors the fileserver main process into
main.go, and creates the routes/ and tasks/
sub-packages.

Moves vic-ui plugin dependencies to fileserver. This includes:
 - vic/lib/install/ova
 - vic/lib/install/plugin
- vic/tagvm/
Additionally, refactors ovatools/vic-ui/ui/ui.go to plugin.go that
doesn't include any CLI flags.

Automates the plugin install process and improves
logging in the fileserver:
 - Add trace.Op logging to fileserver tasks
 - Require vcenter thumprint on psc registration
 - Install VIC UI plugins in the initialization process
 - Attaches a managed tag to the Appliance VM
 - Performs a plugin install during the appliance upgrade
   process using the /plugin API.

Fixes #1433, #637, #1720, #1702 and #1789.
wjun pushed a commit that referenced this pull request Aug 27, 2018
Introduces caching of the vic-ui plugin artifacts as a component
of the ova. Updates the fileserver provisioner to package vic-ui
with the correct version numbers.

Creates the Fileserver Thumbprint API to return the
thumbprint of a given target ip address or fqdn.
Also refactors the fileserver main process into
main.go, and creates the routes/ and tasks/
sub-packages.

Moves vic-ui plugin dependencies to fileserver. This includes:
 - vic/lib/install/ova
 - vic/lib/install/plugin
- vic/tagvm/
Additionally, refactors ovatools/vic-ui/ui/ui.go to plugin.go that
doesn't include any CLI flags.

Automates the plugin install process and improves
logging in the fileserver:
 - Add trace.Op logging to fileserver tasks
 - Require vcenter thumprint on psc registration
 - Install VIC UI plugins in the initialization process
 - Attaches a managed tag to the Appliance VM
 - Performs a plugin install during the appliance upgrade
   process using the /plugin API.

Fixes #1433, #637, #1720, #1702 and #1789.
wjun pushed a commit that referenced this pull request Aug 29, 2018
Introduces caching of the vic-ui plugin artifacts as a component
of the ova. Updates the fileserver provisioner to package vic-ui
with the correct version numbers.

Creates the Fileserver Thumbprint API to return the
thumbprint of a given target ip address or fqdn.
Also refactors the fileserver main process into
main.go, and creates the routes/ and tasks/
sub-packages.

Moves vic-ui plugin dependencies to fileserver. This includes:
 - vic/lib/install/ova
 - vic/lib/install/plugin
- vic/tagvm/
Additionally, refactors ovatools/vic-ui/ui/ui.go to plugin.go that
doesn't include any CLI flags.

Automates the plugin install process and improves
logging in the fileserver:
 - Add trace.Op logging to fileserver tasks
 - Require vcenter thumprint on psc registration
 - Install VIC UI plugins in the initialization process
 - Attaches a managed tag to the Appliance VM
 - Performs a plugin install during the appliance upgrade
   process using the /plugin API.

Fixes #1433, #637, #1720, #1702 and #1789.
wjun pushed a commit that referenced this pull request Aug 29, 2018
Introduces caching of the vic-ui plugin artifacts as a component
of the ova. Updates the fileserver provisioner to package vic-ui
with the correct version numbers.

Creates the Fileserver Thumbprint API to return the
thumbprint of a given target ip address or fqdn.
Also refactors the fileserver main process into
main.go, and creates the routes/ and tasks/
sub-packages.

Moves vic-ui plugin dependencies to fileserver. This includes:
 - vic/lib/install/ova
 - vic/lib/install/plugin
- vic/tagvm/
Additionally, refactors ovatools/vic-ui/ui/ui.go to plugin.go that
doesn't include any CLI flags.

Automates the plugin install process and improves
logging in the fileserver:
 - Add trace.Op logging to fileserver tasks
 - Require vcenter thumprint on psc registration
 - Install VIC UI plugins in the initialization process
 - Attaches a managed tag to the Appliance VM
 - Performs a plugin install during the appliance upgrade
   process using the /plugin API.

Fixes #1433, #637, #1720, #1702 and #1789.
wjun pushed a commit that referenced this pull request Aug 30, 2018
Introduces caching of the vic-ui plugin artifacts as a component
of the ova. Updates the fileserver provisioner to package vic-ui
with the correct version numbers.

Creates the Fileserver Thumbprint API to return the
thumbprint of a given target ip address or fqdn.
Also refactors the fileserver main process into
main.go, and creates the routes/ and tasks/
sub-packages.

Moves vic-ui plugin dependencies to fileserver. This includes:
 - vic/lib/install/ova
 - vic/lib/install/plugin
- vic/tagvm/
Additionally, refactors ovatools/vic-ui/ui/ui.go to plugin.go that
doesn't include any CLI flags.

Automates the plugin install process and improves
logging in the fileserver:
 - Add trace.Op logging to fileserver tasks
 - Require vcenter thumprint on psc registration
 - Install VIC UI plugins in the initialization process
 - Attaches a managed tag to the Appliance VM
 - Performs a plugin install during the appliance upgrade
   process using the /plugin API.

Fixes #1433, #637, #1720, #1702 and #1789.
wjun pushed a commit that referenced this pull request Aug 30, 2018
Introduces caching of the vic-ui plugin artifacts as a component
of the ova. Updates the fileserver provisioner to package vic-ui
with the correct version numbers.

Creates the Fileserver Thumbprint API to return the
thumbprint of a given target ip address or fqdn.
Also refactors the fileserver main process into
main.go, and creates the routes/ and tasks/
sub-packages.

Moves vic-ui plugin dependencies to fileserver. This includes:
 - vic/lib/install/ova
 - vic/lib/install/plugin
- vic/tagvm/
Additionally, refactors ovatools/vic-ui/ui/ui.go to plugin.go that
doesn't include any CLI flags.

Automates the plugin install process and improves
logging in the fileserver:
 - Add trace.Op logging to fileserver tasks
 - Require vcenter thumprint on psc registration
 - Install VIC UI plugins in the initialization process
 - Attaches a managed tag to the Appliance VM
 - Performs a plugin install during the appliance upgrade
   process using the /plugin API.

Fixes #1433, #637, #1720, #1702 and #1789.
wjun pushed a commit that referenced this pull request Aug 30, 2018
Introduces caching of the vic-ui plugin artifacts as a component
of the ova. Updates the fileserver provisioner to package vic-ui
with the correct version numbers.

Creates the Fileserver Thumbprint API to return the
thumbprint of a given target ip address or fqdn.
Also refactors the fileserver main process into
main.go, and creates the routes/ and tasks/
sub-packages.

Moves vic-ui plugin dependencies to fileserver. This includes:
 - vic/lib/install/ova
 - vic/lib/install/plugin
- vic/tagvm/
Additionally, refactors ovatools/vic-ui/ui/ui.go to plugin.go that
doesn't include any CLI flags.

Automates the plugin install process and improves
logging in the fileserver:
 - Add trace.Op logging to fileserver tasks
 - Require vcenter thumprint on psc registration
 - Install VIC UI plugins in the initialization process
 - Attaches a managed tag to the Appliance VM
 - Performs a plugin install during the appliance upgrade
   process using the /plugin API.

Fixes #1433, #637, #1720, #1702 and #1789.
wjun pushed a commit that referenced this pull request Aug 30, 2018
Introduces caching of the vic-ui plugin artifacts as a component
of the ova. Updates the fileserver provisioner to package vic-ui
with the correct version numbers.

Creates the Fileserver Thumbprint API to return the
thumbprint of a given target ip address or fqdn.
Also refactors the fileserver main process into
main.go, and creates the routes/ and tasks/
sub-packages.

Moves vic-ui plugin dependencies to fileserver. This includes:
 - vic/lib/install/ova
 - vic/lib/install/plugin
- vic/tagvm/
Additionally, refactors ovatools/vic-ui/ui/ui.go to plugin.go that
doesn't include any CLI flags.

Automates the plugin install process and improves
logging in the fileserver:
 - Add trace.Op logging to fileserver tasks
 - Require vcenter thumprint on psc registration
 - Install VIC UI plugins in the initialization process
 - Attaches a managed tag to the Appliance VM
 - Performs a plugin install during the appliance upgrade
   process using the /plugin API.

Fixes #1433, #637, #1720, #1702 and #1789.
wjun pushed a commit that referenced this pull request Aug 31, 2018
Introduces caching of the vic-ui plugin artifacts as a component
of the ova. Updates the fileserver provisioner to package vic-ui
with the correct version numbers.

Creates the Fileserver Thumbprint API to return the
thumbprint of a given target ip address or fqdn.
Also refactors the fileserver main process into
main.go, and creates the routes/ and tasks/
sub-packages.

Moves vic-ui plugin dependencies to fileserver. This includes:
 - vic/lib/install/ova
 - vic/lib/install/plugin
- vic/tagvm/
Additionally, refactors ovatools/vic-ui/ui/ui.go to plugin.go that
doesn't include any CLI flags.

Automates the plugin install process and improves
logging in the fileserver:
 - Add trace.Op logging to fileserver tasks
 - Require vcenter thumprint on psc registration
 - Install VIC UI plugins in the initialization process
 - Attaches a managed tag to the Appliance VM
 - Performs a plugin install during the appliance upgrade
   process using the /plugin API.

Fixes #1433, #637, #1720, #1702 and #1789.
wjun pushed a commit that referenced this pull request Aug 31, 2018
Introduces caching of the vic-ui plugin artifacts as a component
of the ova. Updates the fileserver provisioner to package vic-ui
with the correct version numbers.

Creates the Fileserver Thumbprint API to return the
thumbprint of a given target ip address or fqdn.
Also refactors the fileserver main process into
main.go, and creates the routes/ and tasks/
sub-packages.

Moves vic-ui plugin dependencies to fileserver. This includes:
 - vic/lib/install/ova
 - vic/lib/install/plugin
- vic/tagvm/
Additionally, refactors ovatools/vic-ui/ui/ui.go to plugin.go that
doesn't include any CLI flags.

Automates the plugin install process and improves
logging in the fileserver:
 - Add trace.Op logging to fileserver tasks
 - Require vcenter thumprint on psc registration
 - Install VIC UI plugins in the initialization process
 - Attaches a managed tag to the Appliance VM
 - Performs a plugin install during the appliance upgrade
   process using the /plugin API.

Fixes #1433, #637, #1720, #1702 and #1789.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants