Initial cherry-picks for 1.4.2 #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hickeng
approved these changes
Jul 10, 2018
…mware#1630) (vmware#1875) After ca.crt and token.properties are copied to Harbor's directory the owner changed to root. This became a problem after Harbor stop running chown in container. This commit change the owner to 10000:10000 after it's copied. (cherry picked from commit d42c6d9)
The builder OVF used to construct the OVA has hard-coded disk sizes. Correct these to match the final size of the VMDKs to avoid warnings during the OVA deployment process. Refactor to pass image data from build-main to build-disks to avoid duplication of image names. (cherry picked from commit 62bccb8)
…e#1875) As described in installer/docs/BUILD.md, our release process involves several steps: a tag build, a staging build, and a release build. Fully connecting these steps with automation is undesirable; we don't want to stage all tag builds and we want to manually inspect staged builds before deciding to release them. However, requiring users to manually assemble the appropriate command for the next step of the process is error prone. Instead, we output a script containing the next command for them to copy and run. (cherry picked from commit 840ed86)
…#1875) As documented in installer/docs/RELEASE.md, our process is to include filesize and checksum information when publishing a release on GitHub. Output that information in a structured way during the build process to ensure that accurate information can be easily posted. Include this output for all published builds to allow integrity to be verified in all cases. (cherry picked from commit 4459076)
zjs
added a commit
that referenced
this pull request
Jul 17, 2018
The builder OVF used to construct the OVA has hard-coded disk sizes. Correct these to match the final size of the VMDKs to avoid warnings during the OVA deployment process. Refactor to pass image data from build-main to build-disks to avoid duplication of image names. (cherry picked from commit 62bccb8)
zjs
added a commit
that referenced
this pull request
Jul 17, 2018
As described in installer/docs/BUILD.md, our release process involves several steps: a tag build, a staging build, and a release build. Fully connecting these steps with automation is undesirable; we don't want to stage all tag builds and we want to manually inspect staged builds before deciding to release them. However, requiring users to manually assemble the appropriate command for the next step of the process is error prone. Instead, we output a script containing the next command for them to copy and run. (cherry picked from commit 840ed86)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick: