Cherry-pick: Merge branch Feature/auto-vic-ui-plugin (#1979) #1998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We switch ui plugin registration from running manual commands of install.sh or upgrade.sh to automation. A set of rest apis are hosted on the VIC appliance fileserver. During the appliance initialization, index.html page will send a post request to the plugin install api, which will prepare the plugin and register the plugin to vCenter. A thumbprint verification page is shown to enhance security, e.g. a wrong vCenter or a man-in-the-middle attack. In case there is an old ui plugin in vCenter already, the new VIC appliance will overwrite the old ui plugin and register a new one. UI plugin registration is also integrated into upgrade.sh, so the UI plugin can be upgraded as well when running upgrade.sh for VIC appliance upgrade. With UI plugin auto registration, we do not need the manual ui install/upgrade.sh scripts and vic-ui-* commands anymore. UI plugin registration is set to be installed by default during initialization and upgrade, but users can also disable the installation by uncheck the installation option. (cherry picked from commit 0220fd5)
DanielXiao
approved these changes
Aug 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We switch ui plugin registration from running manual commands of install.sh or upgrade.sh to automation. A set of rest apis are hosted on the VIC appliance fileserver. During the appliance initialization, index.html page will send a post request to the plugin install api, which will prepare the plugin and register the plugin to vCenter.
A thumbprint verification page is shown to enhance security, e.g. a wrong vCenter or a man-in-the-middle attack.
In case there is an old ui plugin in vCenter already, the new VIC appliance will overwrite the old ui plugin and register a new one.
UI plugin registration is also integrated into upgrade.sh, so the UI plugin can be upgraded as well when running upgrade.sh for VIC appliance upgrade.
With UI plugin auto registration, we do not need the manual ui install/upgrade.sh scripts and vic-ui-* commands anymore.
UI plugin registration is set to be installed by default during initialization and upgrade, but users can also disable the installation by uncheck the installation option.
(cherry picked from commit 0220fd5)
VIC Appliance Checklist:
masterbranchIf this is a feature or change to existing functionality, consider areas of impact with the Impact
Assessment Checklist
Cherry picks: 0220fd5
From PR: #1979