Update document to reflect vic ui build change #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjs
requested changes
Sep 5, 2018
| specified by their respective URLs, Admiral tag `vic_v1.1.1`, and VIC Machine Server tag `latest`. | ||
| ``` | ||
| ./build/build.sh ova-dev --admiral v1.1.1 --harbor https://example.com/harbor.tgz --vicengine https://example.com/vic_XXXX.tar.gz --vicmachineserver latest | ||
| ./build/build.sh ova-dev --admiral v1.1.1 --harbor https://example.com/harbor.tgz --vicengine https://example.com/vic_XXXX.tar.gz --vicui https://example.com/vic_ui_XXXX.tar.gz --vicmachineserver latest | ||
| ``` | ||
|
|
||
| Note: the VIC Engine artifact used when building the OVA must be named following the `vic_*.tar.gz` format. |
There was a problem hiding this comment.
Note: the VIC Engine artifact used when building the OVA must be named following the
vic_*.tar.gzformat.
This is required by the OVA in order to automatically configure the VIC Engine UI plugins correctly for installation.
Is this still true?
There was a problem hiding this comment.
Since vic_*.tar.gz did not include vic ui codes anymore, I think we can remove this note.
| @@ -141,7 +142,7 @@ VIC Product build is auto-triggered from the successful completion of the follow | |||
|
|
|||
| [Harbor](https://ci-vic.vmware.com/vmware/harbor) | |||
|
|
|||
| There is also a separate build for [VIC UI](https://ci-vic.vmware.com/vmware/vic-ui) which publishes the [artifact](https://console.cloud.google.com/storage/browser/vic-ui-builds) consumed by VIC Engine builds. VIC Engine publishes vic engine artifacts and vic machine server image. | |||
| There is also a separate build for [VIC UI](https://ci-vic.vmware.com/vmware/vic-ui) which publishes the [artifact](https://console.cloud.google.com/storage/browser/vic-ui-builds) consumed by VIC Product builds. VIC Engine publishes vic engine artifacts and vic machine server image. | |||
| Harbor build publishes harbor installer and Admiral build publishes admiral image. All these artifacts are published to Google cloud except Admiral image which is published to Docker hub. | |||
|
|
|||
| ### Dependency Relationship | |||
There was a problem hiding this comment.
A table should be added to this section for vic-ui.
DanielXiao
reviewed
Sep 7, 2018
installer/docs/BUILD.md
Outdated
| ``` | ||
|
|
||
| Note: the VIC Engine artifact used when building the OVA must be named following the `vic_*.tar.gz` format. |
There was a problem hiding this comment.
Is the name convention changed? I think it is correct.
DanielXiao
approved these changes
Sep 7, 2018
zjs
reviewed
Sep 7, 2018
installer/docs/BUILD.md
Outdated
| @@ -172,6 +172,14 @@ The version of each dependency VIC Product consumes varies based on the type of | |||
| |`tag` (other) | latest build published to [`vic-engine-releases`][vr] | latest build published to [`vic-engine-releases`][vr] | | |||
| |`deployment` | manually specified | manually specified | | |||
|
|
|||
| | vic-ui | `master` | `releases/*` | | |||
| | -----------------------:| ------------------------------------------------------- | -------------------------------------------------------------- | | |||
| |`pull_request` | latest build published to [`vic-ui-builds`][vb] | latest build published to [`vic-ui-builds/releases/*`][vb] | | |||
There was a problem hiding this comment.
The links here still go to the vic-engine-* buckets. (See line 194-195, below; you'll want to define new reference-style links below.)
zjs
approved these changes
Sep 10, 2018
wjun
added a commit
to wjun/vic-product
that referenced
this pull request
Sep 11, 2018
(cherry picked from commit 34af3ab)
wjun
added a commit
to wjun/vic-product
that referenced
this pull request
Sep 12, 2018
(cherry picked from commit 34af3ab)
wjun
added a commit
that referenced
this pull request
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1951