Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating license files from version 1.3 to 1.4 #453

Merged
merged 2 commits into from
May 1, 2018

Conversation

lmalvins
Copy link
Contributor

@lmalvins lmalvins commented May 1, 2018

Fixes #

PR acceptance checklist:

[ ] All unit tests pass
[ ] All e2e tests pass
[ ] Unit test(s) included*
[ ] e2e test(s) included*
[ ] Screenshot attached and UX approved*

*if applicable, add n/a if not

@codecov-io
Copy link

codecov-io commented May 1, 2018

Codecov Report

Merging #453 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #453   +/-   ##
======================================
  Coverage    66.8%   66.8%           
======================================
  Files          60      60           
  Lines        2711    2711           
  Branches      477     477           
======================================
  Hits         1811    1811           
  Misses        612     612           
  Partials      288     288

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85a5d4d...d49d0f5. Read the comment docs.

Copy link
Contributor

@mdubya66 mdubya66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files typically need cleaning up to fix the line wrap issues. can we revert?

@jak-atx
Copy link
Contributor

jak-atx commented May 1, 2018

@mdubya66 what line wrap issues? What do we need to fix exactly?

I already had asked Luis to check the formatting and special characters, and it looks ok to me. Let us know if you're seeing something that doesn't look right.

@jak-atx
Copy link
Contributor

jak-atx commented May 1, 2018

I think I see now, you are referring to the horizontal scrolling with the lines too long. @lmalvins please update.

lmalvins added a commit to lmalvins/vic-ui that referenced this pull request May 1, 2018
* Updating from version 1.3 to 1.4

* adding open source license terms
jak-atx pushed a commit that referenced this pull request May 3, 2018
)

* Updating license files from version 1.3 to 1.4 (#453)

* Updating from version 1.3 to 1.4

* adding open source license terms

* wrapping text to make sure the files are viewable without horizontal scrolling (#456)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants