-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating license files from version 1.3 to 1.4 #453
Conversation
Codecov Report
@@ Coverage Diff @@
## master #453 +/- ##
======================================
Coverage 66.8% 66.8%
======================================
Files 60 60
Lines 2711 2711
Branches 477 477
======================================
Hits 1811 1811
Misses 612 612
Partials 288 288 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These files typically need cleaning up to fix the line wrap issues. can we revert?
@mdubya66 what line wrap issues? What do we need to fix exactly? I already had asked Luis to check the formatting and special characters, and it looks ok to me. Let us know if you're seeing something that doesn't look right. |
I think I see now, you are referring to the horizontal scrolling with the lines too long. @lmalvins please update. |
* Updating from version 1.3 to 1.4 * adding open source license terms
Fixes #
PR acceptance checklist:
[ ] All unit tests pass
[ ] All e2e tests pass
[ ] Unit test(s) included*
[ ] e2e test(s) included*
[ ] Screenshot attached and UX approved*
*if applicable, add n/a if not