Merge branch feature/auto-vic-ui-plugin #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the vic-ui scripts to the vic-product repo. Fixes vmware/vic-product#1433.
zjs
requested changes
Aug 27, 2018
There was a problem hiding this comment.
Update vic-ui downstream triggers to vic-product instead of vic 529bcfb
This should be reviewed separately, as a PR targeting the feature branch.
Edit: As discussed out-of-band, we will violate the process this time in order to expedite merge of the feature branch into master to meet the RC1 deadline.
zjs
previously requested changes
Aug 28, 2018
Since we move ui registration codes to vic-product, we need to trigger vic-product now once vic-ui has changes.
wjun
force-pushed
the
feature/auto-vic-ui-plugin
branch
from
529bcfb to
e93a62d
Compare
DanielXiao
approved these changes
Aug 31, 2018
wjun
added a commit
to wjun/vic-ui
that referenced
this pull request
Aug 31, 2018
The ui plugin install/upgrade/uninstall scripts have been reimplemented in vic-product as rest apis, the registration codes have been moved to vic-product as well. These scripts are removed. Update Downstream product trigger from vic to vic-product to reflect the relationship change. (cherry picked from commit 594baa3)
wjun
added a commit
that referenced
this pull request
Aug 31, 2018
The ui plugin install/upgrade/uninstall scripts have been reimplemented in vic-product as rest apis, the registration codes have been moved to vic-product as well. These scripts are removed. Update Downstream product trigger from vic to vic-product to reflect the relationship change. (cherry picked from commit 594baa3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ui plugin install/upgrade/uninstall scripts have been reimplemented in vic-product as rest apis, the registration codes have been moved to vic-product as well. These scripts are be removed.
Update Downstream product trigger from vic to vic-product to reflect the relationship change.