fix certificate chain will not show vic plugin #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjun
reviewed
Jun 5, 2019
h5c/vic-service/src/main/java/com/vmware/utils/ssl/ThumbprintTrustManager.java
Show resolved
Hide resolved
Signed-off-by: Meina Zhou <[email protected]>
wjun
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certificate chain environment. Java ssl trustManager will get multiple certs in the backend.
The old logic will suppose each certs will be in the vcenter server info thumbprint sets. Actually, in this case only one cert thumbprint will in the thumbprint sets. So this logic need to be updated. Modify the logic to suppose vcenter sets will match any of the cert thumbprint from session. If none of the cert thumbprint match the vcenter thumbprint , then throw the exception.