Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vic-machine-server cert path #7258

Merged
merged 2 commits into from
Feb 9, 2018
Merged

Update vic-machine-server cert path #7258

merged 2 commits into from
Feb 9, 2018

Conversation

andrewtchin
Copy link
Contributor

@andrewtchin andrewtchin requested review from zjs and AngieCris February 5, 2018 17:13
@andrewtchin andrewtchin force-pushed the vic-machine-server-cert-location branch from 57db945 to 677ab3d Compare February 5, 2018 17:14
zjs
zjs approved these changes Feb 8, 2018
View reviewed changes
Copy link
Member

@zjs zjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me.

Perhaps you already plan to tweak things before submitting, but in case not: I think the commit message could be a bit more helpful.

@andrewtchin andrewtchin merged commit b308d08 into vmware:master Feb 9, 2018
@andrewtchin andrewtchin deleted the vic-machine-server-cert-location branch February 9, 2018 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjs zjs zjs approved these changes

@AngieCris AngieCris AngieCris approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewtchin @zjs @AngieCris @vmwclabot