Avoid integer overflow in dhcp renewal #8154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that we do not get an integer overflow after 64 contiguous failures to renew a DHCP lease. That was resulting in a divide-by-zero and, depending on how the runtime handling went, a silent exit or a panic.
zjs
approved these changes
Jul 25, 2018
wjun
approved these changes
Jul 26, 2018
zjs
pushed a commit
to zjs/vic
that referenced
this pull request
Aug 6, 2018
This ensures that we do not get an integer overflow after 64 contiguous failures to renew a DHCP lease. That was resulting in a divide-by-zero and, depending on how the runtime handling went, a silent exit or a panic. (cherry picked from commit c119a8a)
hickeng
pushed a commit
that referenced
this pull request
Aug 6, 2018
This ensures that we do not get an integer overflow after 64 contiguous failures to renew a DHCP lease. That was resulting in a divide-by-zero and, depending on how the runtime handling went, a silent exit or a panic. (cherry picked from commit c119a8a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that we do not get an integer overflow after 64 contiguous
failures to renew a DHCP lease. That was resulting in a divide-by-zero
and, depending on how the runtime handling went, a silent exit or a panic.
It's unconfirmed whether it fixes #7680 but may well do so.
Related: #7680
Fixes: #8112