Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IAC-762 Address vulnerability in xml2js #126

Conversation

ivo-kotev
Copy link
Contributor

@ivo-kotev ivo-kotev commented Apr 10, 2023

Description

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have tested against live vRO/vRA, if applicable
  • My changes have been rebased and squashed to the minimal number of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

Release Notes

Screenshot

Related issues and PRs

@ivo-kotev ivo-kotev requested a review from a team as a code owner April 10, 2023 06:31
@Michaelpalacce
Copy link
Collaborator

Vulnerability in question:

xml2js version 0.4.23 allows an external attacker to edit or add new properties to an object. This is possible because the application does not properly validate incoming JSON keys, thus allowing the proto property to be edited.

@ivo-kotev ivo-kotev merged commit 1560082 into master Apr 10, 2023
@ivo-kotev ivo-kotev deleted the feature/IAC-762-xml2js-is-vulnerable-to-prototype-pollution-25 branch April 10, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants