Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support creating vRA 8 projects and add push/pull tasks for such… #54

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

nblagoev
Copy link
Contributor

@nblagoev nblagoev commented Dec 3, 2019

Description

  • Support creation of vRA 8 projects using the New Project command.
  • Add tasks (push/pull) to Cmd+Shift+B for vRA 8 projects

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have tested against live vRO/vRA, if applicable
  • My changes have been rebased and squashed to the minimal number of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixed #XXX - or Closed #XXX - prefix to auto-close the issue

Testing

Tested push/pull/all against live vRA 8 environment. Tested New Project as well.

Release Notes

  • Support creation of vRA 8 projects using the New Project command.
  • Add tasks (push/pull) to Cmd+Shift+B for vRA 8 projects

@nblagoev nblagoev requested a review from a team as a code owner December 3, 2019 12:55
@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #54 into master will decrease coverage by 0.28%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
- Coverage    48.6%   48.31%   -0.29%     
==========================================
  Files          38       38              
  Lines         679      683       +4     
  Branches       87       88       +1     
==========================================
  Hits          330      330              
- Misses        349      353       +4

@nblagoev nblagoev force-pushed the feature/support-vra-8-project-type branch from 210397d to f017c38 Compare December 3, 2019 13:31
Copy link
Contributor

@krisdimitrov krisdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great feature!

@nblagoev nblagoev changed the title Support creating vRA 8 projects and add push/pull tasks for such projects Support creating vRA 8 projects and add push/pull tasks for such… Dec 3, 2019
@nblagoev nblagoev merged commit 239a2e5 into master Dec 3, 2019
@nblagoev nblagoev deleted the feature/support-vra-8-project-type branch December 3, 2019 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants