Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gulpfile #67

Merged
merged 1 commit into from
Apr 15, 2020
Merged

update gulpfile #67

merged 1 commit into from
Apr 15, 2020

Conversation

vmanasiev
Copy link
Contributor

Signed-off-by: Valentin [email protected]

Description

The build fails on windows machines for two reasons

  • The child process does not always return return code ( returns null), adding parameter shell:true fixes this issue
  • The pbjs and pbts scripts found in the protobufjs/bin folder are only shell compatible. There are two ways to fix the issue. Either execute those with node and pass pbjs path as parameter or change the path to nodejs_modules/.bin/pbjs where you can also find pbjs.cmd and pbts.cmd (just as it is done with tsc and vsce

Signed-off-by: Valentin <[email protected]>
@vmanasiev vmanasiev requested a review from a team as a code owner April 13, 2020 16:17
@welcome
Copy link

welcome bot commented Apr 13, 2020

Thank you for taking the time to contribute! We'll check this out soon and let you know if we have any questions or feedback.
If you haven't already, please be sure to check out the contributing guidelines.

@codecov
Copy link

codecov bot commented Apr 13, 2020

Codecov Report

Merging #67 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #67   +/-   ##
=======================================
  Coverage   52.09%   52.09%           
=======================================
  Files          39       39           
  Lines         741      741           
  Branches      101      101           
=======================================
  Hits          386      386           
  Misses        355      355           

@nblagoev nblagoev merged commit 244809d into master Apr 15, 2020
@nblagoev nblagoev deleted the windows-project-build branch April 15, 2020 11:15
@nblagoev nblagoev added platform:windows Issues reproducable on Windows only type:build Build process issues labels Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:windows Issues reproducable on Windows only type:build Build process issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants