Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix windows command for sub projects + add maven type typescript-proj… #68

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

vmanasiev
Copy link
Contributor

-Fixing a problem where the -pl parameter was not applied to windows command lines
-Adding new typescript-project-all type
Signed-off-by: Valentin [email protected]

Description

  1. default task creation
  • The task definition was extended previously to contain specific lines for different os type.
  • As a result further manipulations like adding the -pl parameter were done only on common command line.
  • I have split the default task configuration concern with the default task creation/parsing
  1. matching configured task with tasks.json.
  • The tasks where matched by name. But VSCode adds the task type to the task name when storing it in tasks.json. So I extended the matching pattern to include `${type}: ${name}
  • This does no solve the problem where you see only a single task when you define it in tasks.json. Which is managed partially outside the Task Provider and seems to be out of control. But if you delete the extra parameters like "group" and "problemMatcher" the mixed tasks display starts to work again.
  1. add the new project type: "typescript-project-all"

@vmanasiev vmanasiev requested a review from a team as a code owner April 14, 2020 06:03
@codecov
Copy link

codecov bot commented Apr 14, 2020

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   52.09%   52.09%           
=======================================
  Files          39       39           
  Lines         741      741           
  Branches      101      101           
=======================================
  Hits          386      386           
  Misses        355      355           

Copy link
Contributor

@nblagoev nblagoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Regarding the vanishing tasks when you define something in tasks.json...would you open an issue so we have it tracked?

@nblagoev nblagoev merged commit be3ea24 into master Apr 16, 2020
@nblagoev nblagoev deleted the hotfix/build-task-command-windows-fix branch April 16, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants