Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Node 12 and npm 7, remove deprecated dependencies #95

Merged
merged 10 commits into from
Mar 20, 2021

Conversation

nblagoev
Copy link
Contributor

  • Build using Node 12, since Node 10 is end-of-life at 30/04/2021
  • Bump all dependencies to latest to remove any deprecated packages
  • Migrate to npm 7
    • Yarn 1 is in maintenance mode and the vscode extension publisher (vsce) is not compatible with Yarn 2 due to inability to produce list of production dependencies
    • npm 7 has greatly improved its speed and the ability to do deterministic and reproducible builds
    • npm 7 has support for workspaces which we can leverage when open-sourcing the rest of the vRBT components
  • Fix eslint rule and formatting warnings throughout the code base

@nblagoev nblagoev requested a review from a team as a code owner March 20, 2021 13:55
@codecov
Copy link

codecov bot commented Mar 20, 2021

Codecov Report

Merging #95 (dfdebd1) into master (a15ad4b) will decrease coverage by 0.06%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   50.18%   50.12%   -0.07%     
==========================================
  Files          42       42              
  Lines         805      806       +1     
  Branches      113      113              
==========================================
  Hits          404      404              
- Misses        399      400       +1     
  Partials        2        2              

Signed-off-by: Nikolay Blagoev <[email protected]>
@nblagoev nblagoev merged commit 2487c48 into master Mar 20, 2021
@nblagoev nblagoev deleted the npm7-node12 branch March 20, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants