-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Node 12 and npm 7, remove deprecated dependencies #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nblagoev
commented
Mar 20, 2021
- Build using Node 12, since Node 10 is end-of-life at 30/04/2021
- Bump all dependencies to latest to remove any deprecated packages
- Migrate to npm 7
- Yarn 1 is in maintenance mode and the vscode extension publisher (vsce) is not compatible with Yarn 2 due to inability to produce list of production dependencies
- npm 7 has greatly improved its speed and the ability to do deterministic and reproducible builds
- npm 7 has support for workspaces which we can leverage when open-sourcing the rest of the vRBT components
- Fix eslint rule and formatting warnings throughout the code base
Signed-off-by: Nikolay Blagoev <[email protected]>
…uild time Signed-off-by: Nikolay Blagoev <[email protected]>
Signed-off-by: Nikolay Blagoev <[email protected]>
Signed-off-by: Nikolay Blagoev <[email protected]>
Signed-off-by: Nikolay Blagoev <[email protected]>
…ompatible with VSCE Signed-off-by: Nikolay Blagoev <[email protected]>
Signed-off-by: Nikolay Blagoev <[email protected]>
…events on windows/linux Signed-off-by: Nikolay Blagoev <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
- Coverage 50.18% 50.12% -0.07%
==========================================
Files 42 42
Lines 805 806 +1
Branches 113 113
==========================================
Hits 404 404
- Misses 399 400 +1
Partials 2 2 |
Signed-off-by: Nikolay Blagoev <[email protected]>
Signed-off-by: Nikolay Blagoev <[email protected]>
kgkolev
approved these changes
Mar 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.