Fixes issue rlidwka#128 (Sinopia crash after click in web UI)

vne · Sep 24, 2014 · 74543b4 · 74543b4
1 parent ef074f8
commit 74543b4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/lib/index-web.js b/lib/index-web.js
@@ -73,7 +73,7 @@ module.exports = function(app, config, storage) {
 
 	app.get('/-/readme/:package/:version', function(req, res, next) {
 		storage.get_readme(req.params.package, req.params.version, function(readme) {
-			res.send(marked(readme))
+			readme instanceof Error ? res.send(404) : res.send(marked(readme))
 		})
 	})
 }

diff --git a/lib/static/main.js b/lib/static/main.js
@@ -94,6 +94,15 @@ $(function() {
 
 					$entry.height(height + $readme.outerHeight());
 
+					transitionComplete(function() {
+						$entry.css('height', 'auto');
+					});
+				},
+				error: function(jqxhr, status, error) {
+					var $readme = $("<div class='readme'>No README file</div>").appendTo($entry);
+
+					$entry.height(height + $readme.outerHeight());
+
 					transitionComplete(function() {
 						$entry.css('height', 'auto');
 					});
@@ -962,4 +971,4 @@ module.exports = onScroll;
 })(typeof window != 'undefined' ? window : global);
 
 }).call(this,typeof self !== "undefined" ? self : typeof window !== "undefined" ? window : {})
-},{}]},{},[4])
+},{}]},{},[4])