Remove exceptions from birdsongrec.py #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes NotADirectory and FileNotFound errors raised by `birdsongrec2annot` when `wavpath` doesn't exist or it can't find the wav files in the specified `wavpath`, respectively. My intent was to make sure the files were there, if something else depended on them. But this prevents someone from accessing the annotations if they don't have the wav files. Which is the opposite of the point of this package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes NotADirectory and FileNotFound errors raised by
birdsongrec2annotwhenwavpathdoesn't exist or it can't find the wav files in the specifiedwavpath, respectively.My intent was to make sure the files were there, if something else depended on them.
But this prevents someone from accessing the annotations if they don't have the wav files. Which is the opposite of the point of this package.
It also requires extra logic from a downstream library -- e.g. I'm hitting these errors in vak right now because I'm trying to open the annotation file inside a directory where I don't have (and don't want to have) the wav files -- I'm using the annotations with spectrograms generated from the audio.
So this removes the errors -- they're more trouble than they're worth. Will do the same in the current version, but vak still depends on 3.4.x