Revert "Remove exceptions from birdsongrec.py" #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c228040. We do actually need to check for audio with this annotation format, since we use the audio to get the sampling rate and convert the onsets and offsets from sample numbers to seconds. There might be a more flexible way to handle this long term, but this did not fix the problem I had upstream with vak so I'm just going to revert it for now.
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## maintenance/3.4.x #256 +/- ##
====================================================
Coverage ? 95.69%
====================================================
Files ? 28
Lines ? 766
Branches ? 0
====================================================
Hits ? 733
Misses ? 33
Partials ? 0 ☔ View full report in Codecov by Sentry. |
NickleDave
added a commit
that referenced
this pull request
May 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c228040.
We do actually need to check for audio with this annotation format, since we use the audio to get the sampling rate and convert the onsets and offsets from sample numbers to seconds. There might be a more flexible way to handle this long term, but this did not fix the problem I had upstream with vak so I'm just going to revert it for now.