New package: libsecp256k1-20190311+ee99f12. #10176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cogitri
suggested changes
Mar 23, 2019
| } | ||
|
|
||
| do_build() { | ||
| make -j${XBPS_MAKEJOBS} |
There was a problem hiding this comment.
Use build_style=gnu-configure instead of manually calling make in build and install
| checksum=e4939619f89ca48da1dd5f80435fe5433be9b98b3377cb9d67d1f1e5527db05e | ||
|
|
||
| do_configure() { | ||
| ./autogen.sh |
There was a problem hiding this comment.
do autoreconf -if in pre_configure instead
| pkgname=libsecp256k1 | ||
| version=20190311+ee99f12 | ||
| revision=1 | ||
| _commit=ee99f12f3d8af18bbb9b74cd31907ac1979742ec |
There was a problem hiding this comment.
Please ask upstream for a tagged release, I doubt this will be merged otherwise
There was a problem hiding this comment.
| revision=1 | ||
| _commit=ee99f12f3d8af18bbb9b74cd31907ac1979742ec | ||
| wrksrc="secp256k1-${_commit}" | ||
| makedepends="automake autoconf libtool" |
There was a problem hiding this comment.
These should be hostmakedepends and autoconf isn't required.
maxice8
suggested changes
Mar 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.