Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ipywidgets.HTMLMath output #489

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Fix ipywidgets.HTMLMath output #489

merged 1 commit into from
Jan 27, 2020

Conversation

cnydw
Copy link
Contributor

@cnydw cnydw commented Nov 28, 2019

Fix #488

By executing voila.renderMathJax() after await widgetManager.build_widgets() we are sure that mathjax is working on a page with already built widgets.

I also added .reset() to renderMathJax() to reset the internal flags

@SylvainCorlay
Copy link
Member

Thanks @cnydw this looks good to me!

@jtpio jtpio mentioned this pull request Jan 24, 2020
Closed
jtpio
jtpio approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio
Copy link
Member

jtpio commented Jan 27, 2020

Tried locally and it fixes #488 nicely.

#516 remains though, but can be tackled separately.

martinRenou
martinRenou approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtpio I guess you can merge it!

@jtpio jtpio merged commit 1af1bfa into voila-dashboards:master Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mathjax not working for ipywidgets.HTMLMath output
4 participants
@cnydw @SylvainCorlay @jtpio @martinRenou