Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add render test with pyppeteer - chromium based #574

Conversation

maartenbreddels
Copy link
Member

Using pyppeteer (a python port of puppeteer) we let chrome render the page, make a screenshot, and compare it.

@maartenbreddels maartenbreddels force-pushed the test_render_screenshot branch from 4e1bf63 to 9480351 Compare April 9, 2020 14:02
@maartenbreddels
Copy link
Member Author

maartenbreddels commented Apr 9, 2020

It does not run main.yml when it includes:


    - name: Upload artifacts (from test failures)
        uses: actions/upload-artifact@v1
        if: succeeded() || failed()
        with:
          name: artifacts
          path: artifacts

@maartenbreddels
Copy link
Member Author

sometimes github just silently ignores incorrect yaml.

@maartenbreddels
Copy link
Member Author

As mentioned puppeteer/puppeteer#661 it seems to be important to disable gpu rendering to avoid text rendering differences. Note that the pixel values differed by an absolute value of 1, so it's important to understand the difference, but we should probably expect more platform rendering differences.
We might want to have a tolerance of say 0.1 (10%) for passing tests?

@maartenbreddels
Copy link
Member Author

Finding significant differences between the OS's:
Linux:
print_truth
OSX:
print_testrun
(Note the H and l)

But these should pass when we allow a relative pixel difference of 10%.

This was referenced Jun 24, 2021
@jtpio jtpio closed this in #916 Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant