-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add render test with pyppeteer - chromium based #574
test: add render test with pyppeteer - chromium based #574
Conversation
4e1bf63
to
9480351
Compare
It does not run main.yml when it includes:
|
sometimes github just silently ignores incorrect yaml. |
As mentioned puppeteer/puppeteer#661 it seems to be important to disable gpu rendering to avoid text rendering differences. Note that the pixel values differed by an absolute value of 1, so it's important to understand the difference, but we should probably expect more platform rendering differences. |
Using pyppeteer (a python port of puppeteer) we let chrome render the page, make a screenshot, and compare it.