UpdateJob when Job annotations or labels changed

volcano-sh · May 14, 2020 · b915353 · b915353
1 parent bab40f1
commit b915353
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/pkg/controllers/job/job_controller_handler.go b/pkg/controllers/job/job_controller_handler.go
@@ -85,8 +85,13 @@ func (cc *Controller) updateJob(oldObj, newObj interface{}) {
 
 	// NOTE: Since we only reconcile job based on Spec, we will ignore other attributes
 	// For Job status, it's used internally and always been updated via our controller.
-	if reflect.DeepEqual(newJob.Spec, oldJob.Spec) && newJob.Status.State.Phase == oldJob.Status.State.Phase {
-		klog.V(6).Infof("Job update event is ignored since no update in 'Spec'.")
+	// NOTE: Maybe we should consider annotations and labels
+	if reflect.DeepEqual(newJob.Annotations, oldJob.Annotations) &&
+			reflect.DeepEqual(newJob.Labels, oldJob.Labels) &&
+			reflect.DeepEqual(newJob.Spec, oldJob.Spec) &&
+			newJob.Status.State.Phase == oldJob.Status.State.Phase {
+		klog.V(6).Infof("Job update event is ignored since no update in " +
+		                "'Spec', 'Annotations' and 'Labels'.")
 		return
 	}