Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validate job update #784

Merged
merged 2 commits into from
Apr 30, 2020
Merged

Add validate job update #784

merged 2 commits into from
Apr 30, 2020

Conversation

hzxuzhonghu
Copy link
Collaborator

This is first step for scale up/down

@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 28, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @hzxuzhonghu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 2fe9a050-893a-11ea-bb83-97d0df38a079

@k82cn
Copy link
Member

k82cn commented Apr 28, 2020

/approve

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @hzxuzhonghu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 3f9471e0-8955-11ea-89f9-79127b809311

@k82cn
Copy link
Member

k82cn commented Apr 29, 2020

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @hzxuzhonghu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 356befd0-89ba-11ea-aae4-d3259c3e8c73

@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2020
@k82cn
Copy link
Member

k82cn commented Apr 30, 2020

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2020
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot merged commit 4afb0c3 into volcano-sh:master Apr 30, 2020
k82cn
k82cn reviewed Apr 30, 2020
View reviewed changes
pkg/webhooks/admission/jobs/validate/admit_job.go
}

// jon controller will update the pvc name if not provided
for i := range new.Spec.Volumes {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that means we did not check volumes update here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, we do not check the volume name here, it is auto generated by job controller.

@hzxuzhonghu hzxuzhonghu mentioned this pull request May 8, 2020
Merged
volcano-sh-bot added a commit that referenced this pull request May 8, 2020
@volcano-sh-bot
Merge pull request #793 from hzxuzhonghu/automated-cherry-pick-of-#78…
c5c2534 
…4-origin-release-0.4

Automated cherry pick of #784: Add validate job update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k82cn k82cn k82cn left review comments

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

@yuanchen8911 yuanchen8911 Awaiting requested review from yuanchen8911

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hzxuzhonghu @TravisBuddy @k82cn @volcano-sh-bot