Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default culture arg to give manifest configuration a chance. #155

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

cstkingkey
Copy link
Contributor

fix #148

@volks73
Copy link
Owner

volks73 commented Jan 19, 2022

@cstkingkey Nice work. The default value in the CLI argument explains why the unit tests were passing and the fn culture implementation looked correct. It probably would have taken me a while to find the cause.

I am going to merge this to resolve the issue, but it would be great to add an integration test that covers this at some point.

@volks73 volks73 added the bug label Jan 19, 2022
@volks73 volks73 merged commit 9a6f5e8 into volks73:main Jan 19, 2022
@cstkingkey cstkingkey deleted the culture_fix branch January 20, 2022 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

culture set in Cargo.toml is not used
2 participants