Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix running without --release #164

Merged
merged 1 commit into from
Jun 20, 2022
Merged

fix running without --release #164

merged 1 commit into from
Jun 20, 2022

Conversation

davidkna
Copy link
Contributor

Currently, when building in debug mode and attempting to run the cargo-wix binary, clap panics with:

thread 'main' panicked at 'Argument "license" has the same index as another positional argument

I managed to fix the error by moving all position arguments right after the SubCommand definitions.

@volks73 volks73 self-requested a review June 19, 2022 22:49
@volks73 volks73 added the bug label Jun 19, 2022
volks73
volks73 approved these changes Jun 20, 2022
View reviewed changes
Copy link
Owner

@volks73 volks73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for the PR and fix.

@volks73 volks73 merged commit bd714cf into volks73:main Jun 20, 2022
@davidkna davidkna deleted the fix-debug branch August 16, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volks73 volks73 volks73 approved these changes

Assignees

@davidkna davidkna

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidkna @volks73