-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: clean up path handling #222
Conversation
Gankra
commented
Sep 6, 2023
- Depend on camino to avoid needless conversions of the camino paths cargo_metadata gives us
- Add a StoredPath(Buf) type that is for paths that will get written to output files like main.wxs
- Most interesting part is StoredPathBuf::from_utf8_path
- Clean up code to use new path types more
Currently a draft because I want to do some more testing that this approach is sane |
Experimentally turned on unit test CI for linux/macos, working on enabling more of the tests that make sense (it seems like the initialize::execution unit tests are messed up -- they use set_current_dir but weren't using serial_test, and even if they do every other test is racing them. No idea why this isn't a problem on windows...) |
* Depend on camino to avoid needless conversions of the camino paths cargo_metadata gives us * Add a StoredPath(Buf) type that is for paths that will get written to output files like main.wxs * Most interesting part is StoredPathBuf::from_utf8_path * Clean up code to use new path types more
@volks73 I'm now reasonably confident in the implementation, and have everything except for |
(additional evidence: i pointed the cargo-dist integration PR to this branch and now the snapshots are the same on all platforms -- without me having to regenerate them, so the windows ones never changed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.