Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notion install yarn behavior is inconsistent #123

Closed
benblank opened this issue Aug 22, 2018 · 4 comments
Closed

notion install yarn behavior is inconsistent #123

benblank opened this issue Aug 22, 2018 · 4 comments
Labels

Comments

@benblank
Copy link
Contributor

benblank commented Aug 22, 2018

When running notion install yarn 1, version 1.0.0 is fetched and installed, even though newer versions are available which match that version. This is inconsistent with notion install yarn 1.9 and notion install node 10, both of which fetch and install the latest matching version.

Notion version 0.1.0 on macOS High Sierra.

@benblank benblank added the bug label Aug 22, 2018
2hu12 added a commit to 2hu12/yarn-releases that referenced this issue Nov 27, 2018
The order of yarn releases is from oldest to newest which is converse to [nodejs dist](https://nodejs.org/dist/index.json) and it makes [this issue](volta-cli/volta#123) happen.
@charlespierce
Copy link
Contributor

This appears to have been fixed by #221 hitting the actual Yarn release index instead of our hosted copy.

@dherman
Copy link
Collaborator

dherman commented Dec 19, 2018

@charlespierce Yeah but we could probably merge that PR in yarn-releases for older versions of Notion. WDYT?

@charlespierce
Copy link
Contributor

Agreed, it's worth merging that (and if we continue to add new releases, doing them in the expected reverse order) to support the older versions

@charlespierce
Copy link
Contributor

Merged the yarn-releases PR, so I believe this is fixed for all versions of Notion now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants