Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use debug formatter to properly escape arguments for error log #401

Merged
merged 2 commits into from
May 9, 2019
+2 −1
Merged

Use debug formatter to properly escape arguments for error log #401

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93fc4a9
Use debug formatter to properly escape arguments for error log
charlespierce May 3, 2019
fc93deb
Merge branch 'master' into escape_command_log
charlespierce May 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crates/volta-core/src/error/reporter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,9 @@ fn compose_error_details(err: &VoltaError) -> Option<String> {

/// Combines all the arguments into a single String
fn collect_arguments() -> String {
// The Debug formatter for OsString properly quotes and escapes each value
args_os()
.map(|arg| arg.into_string().unwrap_or(String::from("<UNKNOWN>")))
.map(|arg| format!("{:?}", arg))
.collect::<Vec<String>>()
.join(" ")
}