Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC1 Feedback #73

Closed
apinner opened this issue Mar 25, 2016 · 18 comments
Closed

RC1 Feedback #73

apinner opened this issue Mar 25, 2016 · 18 comments

Comments

@apinner
Copy link
Contributor

apinner commented Mar 25, 2016

I'm going to collate all of my feedback for RC1 here. The system works beautifully for me so 90% of my feedback is UI based.

1. Volume icon on the mobile UI should go green when active and the volume slider is out.
2. Next/Back icons should also do the same as above when they are touched on the mobile UI.
3. Multi room dock image and text not centred.
4. Consistency with capitals throughout the UI.
5. Network status randomly shows red tick.
6. The setting 'Mixer control' is confusing and needs some help documentation.
7. Alarm modal needs some place holder text when no alarms present.
8. Sleep modal inputs are not aligned.
9. Suggestion: When hovering over album art in Queue display a play button overlay. Double click works but this is not clear.
10. When clicking on another device in the multiroom dock, it displays two of the current device. (Will get a screen shot for this).
11. Is it possible to display the bitrate of a radio stream in the playback knob?
12. I occasionally get partial or failed album art loads.
13. Mute still doesn't work for me.
14. System setting to change the background image would be really really awesome!
15. Control a hrefs all need a title tag adding to them for usability.
16. Album title in now playing coloured volumio green would really satisfy my OCD.
17. If you have a lot of items in the queue it can take a long time to load during which the UI is completely unresponsive, Maybe a loading swirl is needed to show something is happening?
18. Need a space after the artist in the play queue, Its currently Artist- Album should be Artist - Album.
19. Input and Buttons when connecting to wireless network are not aligned.
20. If you connect to wired and wireless networks at the same time, the network status columns are not aligned.
21. A force refresh button would be very helpful for wireless networks.
22. There is no way to clear a search once you have done one. Need the ability to clear the form and undo the search.
23. I notice in the search form code there is the magnifier icon but it does not display in the input field.
24. The volume knob just does not work! It's horrible to use at the moment, quite a few reports about this already.
25. A button to completely clear the queue would be very helpful.
26. Jump to top button that appears when scrolling through long lists would also be helpful.

Most are pretty minor, overall its a massive step forward from 1.*

Amazing work!!

@apinner
Copy link
Contributor Author

apinner commented Mar 25, 2016

Screenshots for 10.

multiroom 1
multiroom 2

apinner added a commit that referenced this issue Mar 26, 2016
List here: #73
Fixes for
1. Volume button green on focus in mobile UI.
2. Skip button green on touch in mobile UI.
3. Multi room dock images and text centered.
4. Capitalized first letters for panel titles for consistency.
15. Added titles to all major controls.
16. Album title changed to green, looks better imo.
@balbuze
Copy link
Contributor

balbuze commented Mar 26, 2016

  • for multiroom I rename one of my two device but previous is still displayed. And when I switch from one to other the round time is displayed several times (one is add each switch)
  • mute button does not work
  • In mobile UI, track with ' in name can't get album art displayed (ok in desktop)
  • with a DAC without hardware volume, option are still available (curve , max vol )
  • with a DAC without hardware volume, no software volume available ( softvol from alsa)
    multiroomp

@apinner
Copy link
Contributor Author

apinner commented Apr 5, 2016

Updated first post.

@apinner
Copy link
Contributor Author

apinner commented Apr 5, 2016

I also just got the same issue as @balbuze with the multiple playback knobs being displayed.

My Multiroom problem just got a whole lot worse too. I rebooted my development Pi a couple of times and now look at my Multiroom dock, they are multiplying!!

multiroom

@apinner
Copy link
Contributor Author

apinner commented Apr 6, 2016

On the alarm modal, if you have no playlists present then the dropdown box disappears when you select it. All of the controls are also very misaligned

alarm-modal

@balbuze
Copy link
Contributor

balbuze commented Apr 9, 2016

In mobile UI, when you select an option from a list (like DAC, buffer..) it opens the keyboard.

@apinner
Copy link
Contributor Author

apinner commented Apr 9, 2016

@balbuze It looks like it might be a bug in angular angular-ui/ui-select#818

@apinner
Copy link
Contributor Author

apinner commented Apr 12, 2016

When clicking rescan under My Music it would be nice to have some feedback that something is actually happening. Swirly wheel, progress bar or something.

@apinner
Copy link
Contributor Author

apinner commented Apr 18, 2016

Thinking about how to implement the ability to change the default background.

How about just an smb share to /src/app/themes/volumio/assets/backgrounds

we could just read the contents of that directory for *.png *.jpg etc and populate a dropdown under system settings?

@volumio
Copy link
Owner

volumio commented Apr 18, 2016

We can add the backend for backrounds in a new plugin (maybe under miscellanea, look_and_feel).

We'll have a default background exposed via an express route (something like /background ) so on default it will show the black one. When we change the settings in that plugin we just change the response of that route...
What do you think?

@apinner
Copy link
Contributor Author

apinner commented Apr 18, 2016

Sounds like an even better idea! 👍

@volumio
Copy link
Owner

volumio commented Apr 18, 2016

I'm flooded with other stuff in this moment... Would you like to start this (either back or FE)... And I'ìll jump in in a couple of days..

@apinner
Copy link
Contributor Author

apinner commented Apr 18, 2016

I'm really short on time myself at the moment, if I get an evening free this week then i'll take a look.

@volumio
Copy link
Owner

volumio commented Apr 18, 2016

We're on the same boat then lol

@apinner
Copy link
Contributor Author

apinner commented Apr 20, 2016

The volume slider on mobile is nice, but tricky to use. There is no feedback or change in the number as you move the slider so you end up guessing where the volume is, so normally takes several attempts to get the right volume.

@kurtommy is it possible for the slider volume number to change with the movement of the slider? It doesn't have to change the volume in real time, just provide some feedback of where the slider is on the scale.

@JHilsberg
Copy link

In the webradio view is a displaying error with the menu.
volumio-webradio
The menu of the fourth item from top is cut from the bar above.

@apinner
Copy link
Contributor Author

apinner commented May 15, 2016

@kurtommy as our angular expert I was wondering if you could offer some advice.

I am working on a set of icons that will show the file format logo in the player control knob. So instead of just mp3 text it will show the mp3 logo, for all of the various formats. For this is have created a load of svg files and our own volumio font (including the logo, note and queue icons).

I have tested this in a dev branch using ng-switch with ng-switch-default being the the original text as a fallback. Which works fine but is there a better way of doing this or is ng-switch the best way?

For example

<div class="footerText"> <span ng-if="trackManager.playerService.state.trackType !== 'webradio'" ng-switch="trackManager.playerService.state.trackType"> <i ng-switch-when="mp3" class="icon-mp3"> </i> <i ng-switch-when="flac" class="icon-flac"> </i> <span ng-switch-default>{{trackManager.playerService.state.trackType}}</span> </span> </div>

@apinner
Copy link
Contributor Author

apinner commented May 17, 2016

@kurtommy Just trying out some of the recent changes, looking excellent!

One issue, the wireless network list. For some reason the panel title has shifted to the bottom of the panel.

wireless-problem

Oh, and the default pattern background doesn't seem to load by default after a fresh install. Not sure if that is by design or if it has been missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants