Fixes issue with un-rendering the camera view

vorjdux · Jun 4, 2015 · 1102a53 · 1102a53
1 parent a9e5b55
commit 1102a53
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/RCTCamera.m b/RCTCamera.m
@@ -84,6 +84,7 @@ - (void)removeReactSubview:(UIView *)subview
 
 - (void)removeFromSuperview
 {
+  [super removeFromSuperview];
   [[NSNotificationCenter defaultCenter] removeObserver:self name:UIDeviceOrientationDidChangeNotification object:nil];
 }
 

diff --git a/package.json b/package.json
@@ -4,13 +4,13 @@
     "type" : "git",
     "url" : "https://github.com/lwansbrough/react-native-camera.git"
   },
-  "version": "0.2.8",
+  "version": "0.2.9",
   "description": "A Camera component for React Native. Also reads barcodes.",
   "main": "Camera.ios.js",
   "author": "Lochlan Wansbrough <[email protected]> (http://lwansbrough.com)",
   "nativePackage": true,
   "peerDependencies": {
-    "react-native": "^0.4.0"
+    "react-native": "^0.4.3"
   },
   "keywords": [
     "react-native",

diff --git a/react-native-camera.podspec b/react-native-camera.podspec
@@ -1,13 +1,14 @@
 Pod::Spec.new do |s|
 
   s.name         = "react-native-camera"
-  s.version      = "0.2.8"
+  s.version      = "0.2.9"
   s.summary      = "A Camera component for React Native. Also reads barcodes."
-  s.homepage     = "http://github.com/lwansbrough/react-native-camera"
+  s.homepage     = "https://github.com/lwansbrough/react-native-camera"
   s.license      = { :type => "MIT", :file => "LICENSE" }
   s.author       = { "Lochlan Wansbrough" => "[email protected]" }
   s.platform     = :ios, "7.0"
-  s.source       = { :git => "http://github.com/lwansbrough/react-native-camera.git", :tag => "v0.2.8" }
+  s.source       = { :git => "https://github.com/lwansbrough/react-native-camera.git", :tag => "v0.2.8" }
   s.source_files = "*.{h,m}"
   s.requires_arc = true
+  s.dependency 'React'
 end
-Original file line number
+Diff line change
@@ Expand Up / @@ -84,6 +84,7 @@ - (void)removeReactSubview:(UIView *)subview @@
     - (void)removeFromSuperview
     {
+      [super removeFromSuperview];
       [[NSNotificationCenter defaultCenter] removeObserver:self name:UIDeviceOrientationDidChangeNotification object:nil];
     }
@@ Expand Down @@