Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new statistics endpoint #253

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

OldMetalmind
Copy link
Member

Closes #252

Description
The new statistics endpoint has more information about the current status of Covid in Portugal

This is a Work In Progress issue, after this PR, we need to build the new statistics UI and improve the Models created.

How To Test
Since the endpoint is not in production or even deployed, it is necessary to build the Dockerfile from the following project: https://github.com/dssg-pt/Docker_COVID_API

With the respective container of the docker image running. Update the class StatusDevApi with the host to your machine IP running the container.

Instructions:

git clone https://github.com/dssg-pt/Docker_COVID_API
cd Docker_COVID_API
docker build -t covid_api .
docker run -it --name some_covid_api -p 8001:5001 covid_api

Changes
✅ Add CovidStatus APIService, Model, and Provider
✅ Add to AppBloc
✅ Add bloc call in Statistics Screen
✅ dartfmt @ root
⚠️ no tests added

The new statistics endpoint has more information

Add Models and APIService for CovidStatus

Fix badly formated variable names

Code refactoring
Copy link
Member

@miguelpruivo miguelpruivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM.

@miguelpruivo miguelpruivo merged commit 3191bca into dev Apr 20, 2020
@miguelpruivo miguelpruivo deleted the task/#252_add_statistics_model_and_network branch April 20, 2020 09:53
Copy link
Collaborator

@Vanethos Vanethos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -40,7 +40,7 @@ void main() async {
/// Pass all uncaught errors from the framework to Crashlytics.
FlutterError.onError = Crashlytics.instance.recordFlutterError;

appConfig = AppConfig.prod;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have different main files, a new issue will be open for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding new Statistics Model & Network
3 participants