-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/#269 ui fixes graphs #274
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me, I've suggested some optional changes. Apply it if you have the time, otherwise it's ok to merge.
), | ||
), | ||
checkHasAgeGroupData(currentStatistics.confirmedRecentByAgeGroup) | ||
? Container() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is in a Column
we can avoid ternary that will add an "invisible" widget to the tree. We can make it if( checkHasAgeGroupData(currentStatistics.confirmedRecentByAgeGroup)) Padding(...)
instead.
male, | ||
female, | ||
}) { | ||
this.male = male == null ? 0 : male; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather have this 0
as default values on the constructor.
@@ -13,6 +13,31 @@ | |||
|
|||
import 'dart:math' as math; | |||
|
|||
///Possible intervals | |||
List<double> intervals = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make it const
.
Description
Not everything is possible to be fixed given the limitations of the library used.
Labels
β - Fixed
π« - Not possible to fixe given current limitations
β - Possible, will be fixed in a new PR
Changes
High Priority
Medium priority
Small priority
-β Style details that don't have a major impact on usability