-
Notifications
You must be signed in to change notification settings - Fork 8
Creating a Pull Request
Likewise the branch rules naming convections, we recommend you to always to create a pull request that follows some procedures.
Those are listed below in order:
-
Run
flutter format .
in your project root folder, just to make sure all files that you have edited follow the Dart formatter 80 line length guideline — however, do not commit files that you didn't added changes, despite being formatted with this; -
Do not check into source control files that shouldn't be added (although .gitignore protects you from this);
-
Create your commit with a description of what has been done and, preferably, with a reference to the issue ID, for example, a possible commit message could be: FIX - Fix API call (#100) and you can also add a commit description whenever needed;
-
When creating the PR, add a small description (that can be automatically taken from the issue description telling what has been done and do not forget to add a reference do closing issue that that PR closes, when applicable (eg. Closes #100). This will automatically close that issue whenever the PR is merged;
-
Always make sure that you are creating a PR to
dev
branch;