Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix domain checks #199

Merged
merged 1 commit into from
Feb 7, 2020
Merged

Conversation

eikehartmann
Copy link
Contributor

@eikehartmann eikehartmann commented Jan 26, 2020

Fixes #198

  • given a domain vouch.github.io as config value vouch.domains and user with email [email protected]

    • expected result: User won't be authorised.
    • actual result: User is authorised.
    • patched result: User won't be authorised.
  • given a domain easy.vouch.io as config value vouch.domains and user with email [email protected]

    • expected result: User won't be authorised.
    • actual result: User is authorised.
    • patched result: User won't be authorised.

From looking at the code, domains.IsUnderManagement(user.Email) which uses domain.Matches() method will create the misbehaviour described above. The PR should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When domains configured, access via email on different domain should not be possible.
2 participants