add default labels visibility in dataset app config + selective labels rendering optimization #7257
pr.yml
on: pull_request
modified-files
28s
teams
0s
Matrix: test / test-python
build
/
changes
31s
build
/
build
2m 17s
e2e
/
test-e2e
17m 15s
lint
/
eslint
51s
test
/
test-app
1m 18s
all-tests
0s
Annotations
9 errors, 22 warnings, and 1 notice
[chromium] › src/oss/specs/grid-tagging.spec.ts:48:1 › grid tagging:
e2e-pw/src/oss/poms/grid/index.ts#L71
1) [chromium] › src/oss/specs/grid-tagging.spec.ts:48:1 › grid tagging ───────────────────────────
TimeoutError: locator.scrollIntoViewIfNeeded: Timeout 19948.168999999994ms exceeded.
Call log:
- attempting scroll into view action
2 × waiting for element to be stable
- element is not visible
- retrying scroll into view action
- waiting 20ms
2 × waiting for element to be stable
- element is not visible
- retrying scroll into view action
- waiting 100ms
37 × waiting for element to be stable
- element is not visible
- retrying scroll into view action
- waiting 500ms
at oss/poms/grid/index.ts:71
69 | .locator("div")
70 | .last()
> 71 | .scrollIntoViewIfNeeded({ timeout: Duration.Seconds(20) });
| ^
72 | }
73 |
74 | async scrollTop() {
at GridPom.scrollBottom (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/grid/index.ts:71:8)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/grid-tagging.spec.ts:52:14
|
[chromium] › src/oss/specs/smoke-tests/saved-views.spec.ts:106:3 › saved views › saved view basic operations:
e2e-pw/src/oss/specs/smoke-tests/saved-views.spec.ts#L100
2) [chromium] › src/oss/specs/smoke-tests/saved-views.spec.ts:106:3 › saved views › saved view basic operations
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Test timeout of 60000ms exceeded while running "beforeEach" hook.
98 |
99 | test.describe.serial("saved views", () => {
> 100 | test.beforeEach(async ({ page, fiftyoneLoader, savedViews }) => {
| ^
101 | await fiftyoneLoader.waitUntilGridVisible(page, datasetName);
102 | await deleteSavedView(savedViews, testView.name);
103 | await deleteSavedView(savedViews, updatedView2.slug);
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/smoke-tests/saved-views.spec.ts:100:8
|
[chromium] › src/oss/specs/smoke-tests/saved-views.spec.ts:106:3 › saved views › saved view basic operations:
e2e-pw/src/oss/fixtures/loader.ts#L69
2) [chromium] › src/oss/specs/smoke-tests/saved-views.spec.ts:106:3 › saved views › saved view basic operations
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: locator.click: Test timeout of 60000ms exceeded.
Call log:
- waiting for getByTestId('selector-result-quickstart-saved-views-ow4jubo')
at oss/fixtures/loader.ts:69
67 |
68 | if (datasetName) {
> 69 | await page.getByTestId(`selector-result-${datasetName}`).click();
| ^
70 | } else {
71 | const firstSelectorResult = page.locator(
72 | "[data-cy=selector-results-container] > div"
at forceDatasetFromSelector (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/fixtures/loader.ts:69:66)
at OssLoader.waitUntilGridVisible (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/fixtures/loader.ts:91:7)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/smoke-tests/saved-views.spec.ts:101:5
|
[chromium] › src/oss/specs/smoke-tests/saved-views.spec.ts:106:3 › saved views › saved view basic operations:
e2e-pw/src/oss/specs/smoke-tests/saved-views.spec.ts#L100
2) [chromium] › src/oss/specs/smoke-tests/saved-views.spec.ts:106:3 › saved views › saved view basic operations
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Test timeout of 60000ms exceeded while running "beforeEach" hook.
98 |
99 | test.describe.serial("saved views", () => {
> 100 | test.beforeEach(async ({ page, fiftyoneLoader, savedViews }) => {
| ^
101 | await fiftyoneLoader.waitUntilGridVisible(page, datasetName);
102 | await deleteSavedView(savedViews, testView.name);
103 | await deleteSavedView(savedViews, updatedView2.slug);
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/smoke-tests/saved-views.spec.ts:100:8
|
[chromium] › src/oss/specs/smoke-tests/saved-views.spec.ts:106:3 › saved views › saved view basic operations:
e2e-pw/src/oss/fixtures/loader.ts#L69
2) [chromium] › src/oss/specs/smoke-tests/saved-views.spec.ts:106:3 › saved views › saved view basic operations
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: locator.click: Test timeout of 60000ms exceeded.
Call log:
- waiting for getByTestId('selector-result-quickstart-saved-views-4tx3zun')
at oss/fixtures/loader.ts:69
67 |
68 | if (datasetName) {
> 69 | await page.getByTestId(`selector-result-${datasetName}`).click();
| ^
70 | } else {
71 | const firstSelectorResult = page.locator(
72 | "[data-cy=selector-results-container] > div"
at forceDatasetFromSelector (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/fixtures/loader.ts:69:66)
at OssLoader.waitUntilGridVisible (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/fixtures/loader.ts:91:7)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/smoke-tests/saved-views.spec.ts:101:5
|
[chromium] › src/oss/specs/smoke-tests/saved-views.spec.ts:136:3 › saved views › saving a view with an already existing name fails:
e2e-pw/src/oss/poms/saved-views.ts#L158
3) [chromium] › src/oss/specs/smoke-tests/saved-views.spec.ts:136:3 › saved views › saving a view with an already existing name fails
TimeoutError: locator.click: Timeout 2000ms exceeded.
Call log:
- waiting for getByTestId('saved-views-create-new')
- locator resolved to <div data-cy="saved-views-create-new" class="sc-iYBOoK sc-hLtZSE iNAxmh enApcp">…</div>
- attempting click action
2 × waiting for element to be visible, enabled and stable
- element is not stable
- retrying click action
- waiting 20ms
- waiting for element to be visible, enabled and stable
- element is not stable
- retrying click action
- waiting 100ms
- waiting for element to be visible, enabled and stable
- element was detached from the DOM, retrying
at oss/poms/saved-views.ts:158
156 | await this.openSelect();
157 | }
> 158 | await this.saveNewViewBtn.click({ timeout: 2000 });
| ^
159 | }
160 |
161 | async savedViewCount(name: string) {
at SavedViewsPom.openCreateModal (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/saved-views.ts:158:31)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/smoke-tests/saved-views.spec.ts:142:5
|
[chromium] › src/oss/specs/smoke-tests/tagger.spec.ts:48:3 › tag › sample tag and label tag loads correct aggregation number on default view:
e2e-pw/src/oss/specs/smoke-tests/tagger.spec.ts#L41
4) [chromium] › src/oss/specs/smoke-tests/tagger.spec.ts:48:3 › tag › sample tag and label tag loads correct aggregation number on default view
Test timeout of 60000ms exceeded while running "beforeEach" hook.
39 | });
40 |
> 41 | test.beforeEach(async ({ page, fiftyoneLoader, sidebar }) => {
| ^
42 | await fiftyoneLoader.waitUntilGridVisible(page, datasetName);
43 | await sidebar.clickFieldCheckbox("ground_truth");
44 | await sidebar.clickFieldCheckbox("predictions");
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/smoke-tests/tagger.spec.ts:41:6
|
[chromium] › src/oss/specs/smoke-tests/tagger.spec.ts:48:3 › tag › sample tag and label tag loads correct aggregation number on default view:
e2e-pw/src/oss/fixtures/loader.ts#L120
4) [chromium] › src/oss/specs/smoke-tests/tagger.spec.ts:48:3 › tag › sample tag and label tag loads correct aggregation number on default view
Error: page.reload: Target page, context or browser has been closed
at oss/fixtures/loader.ts:120
118 | ctx.clearCookies();
119 | ctx.clearPermissions();
> 120 | await page.reload({ waitUntil: "domcontentloaded" });
| ^
121 | await this.waitUntilGridVisible(page, datasetName, options, true);
122 | }
123 | }
at OssLoader.waitUntilGridVisible (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/fixtures/loader.ts:120:20)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/smoke-tests/tagger.spec.ts:42:3
|
[chromium] › src/oss/specs/smoke-tests/tagger.spec.ts:48:3 › tag › sample tag and label tag loads correct aggregation number on default view:
e2e-pw/src/oss/fixtures/loader.ts#L118
4) [chromium] › src/oss/specs/smoke-tests/tagger.spec.ts:48:3 › tag › sample tag and label tag loads correct aggregation number on default view
Error: browserContext.clearCookies: Test timeout of 60000ms exceeded.
at oss/fixtures/loader.ts:118
116 | } else {
117 | const ctx = page.context();
> 118 | ctx.clearCookies();
| ^
119 | ctx.clearPermissions();
120 | await page.reload({ waitUntil: "domcontentloaded" });
121 | await this.waitUntilGridVisible(page, datasetName, options, true);
at OssLoader.waitUntilGridVisible (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/fixtures/loader.ts:118:13)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/smoke-tests/tagger.spec.ts:42:3
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L28
'panelLabel' is assigned a value but never used. Allowed unused vars must match /^_|React/u
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L35
'handlePanelStateChange' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L36
'handlePanelStatePathChange' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L37
'panelSchema' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L38
'data' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L39
'onLoadError' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L41
'pending' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L53
React Hook useEffect has missing dependencies: 'panelId', 'panelName', 'props.onUnLoad', 'setPanelCloseEffect', 'trackEvent', and 'triggerPanelEvent'. Either include them or remove the dependency array
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L126
React Hook useEffect has a missing dependency: 'dimensions'. Either include it or remove the dependency array
|
lint / eslint:
app/packages/operators/src/built-in-operators.ts#L820
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
test / test-python (ubuntu-latest-m, 3.10)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test / test-python (ubuntu-latest-m, 3.11)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test / test-python (ubuntu-latest-m, 3.9)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
e2e / test-e2e:
e2e-pw/src/oss/specs/regression-tests/media-field.spec.ts#L85
Unexpected use of the `.skip()` annotation
|
e2e / test-e2e
Unexpected input(s) 'working-directory', valid inputs are ['path', 'key', 'restore-keys', 'upload-chunk-size', 'enableCrossOsArchive', 'fail-on-cache-miss', 'lookup-only', 'save-always']
|
e2e / test-e2e
Unexpected input(s) 'working-directory', valid inputs are ['path', 'key', 'restore-keys', 'upload-chunk-size', 'enableCrossOsArchive', 'fail-on-cache-miss', 'lookup-only', 'save-always']
|
e2e / test-e2e
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/smoke-tests/field-visibility.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/smoke-tests/field-visibility.spec.ts took 1.5m
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/smoke-tests/quickstart-groups.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/smoke-tests/quickstart-groups.spec.ts took 38.2s
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/groups/sparse-groups.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/groups/sparse-groups.spec.ts took 35.4s
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/sidebar/sidebar.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/sidebar/sidebar.spec.ts took 24.0s
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/selection.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/selection.spec.ts took 22.7s
|
🎭 Playwright Run Summary
4 flaky
[chromium] › src/oss/specs/grid-tagging.spec.ts:48:1 › grid tagging ────────────────────────────
[chromium] › src/oss/specs/smoke-tests/saved-views.spec.ts:106:3 › saved views › saved view basic operations
[chromium] › src/oss/specs/smoke-tests/saved-views.spec.ts:136:3 › saved views › saving a view with an already existing name fails
[chromium] › src/oss/specs/smoke-tests/tagger.spec.ts:48:3 › tag › sample tag and label tag loads correct aggregation number on default view
2 skipped
96 passed (10.7m)
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
dist
|
19.9 MB |
|
playwright-report
|
88 MB |
|