add default labels visibility in dataset app config + selective labels rendering optimization #7259
pr.yml
on: pull_request
modified-files
31s
teams
0s
Matrix: test / test-python
build
/
changes
31s
build
/
build
2m 27s
e2e
/
test-e2e
15m 12s
lint
/
eslint
49s
test
/
test-app
1m 18s
all-tests
0s
Annotations
7 errors, 22 warnings, and 1 notice
test / test-python (ubuntu-latest-m, 3.11)
TypeError: fetch failed
|
[chromium] › src/oss/specs/grid-tagging.spec.ts:48:1 › grid tagging:
e2e-pw/src/oss/poms/grid/index.ts#L71
1) [chromium] › src/oss/specs/grid-tagging.spec.ts:48:1 › grid tagging ───────────────────────────
TimeoutError: locator.scrollIntoViewIfNeeded: Timeout 19985.564999999995ms exceeded.
Call log:
- attempting scroll into view action
2 × waiting for element to be stable
- element is not visible
- retrying scroll into view action
- waiting 20ms
2 × waiting for element to be stable
- element is not visible
- retrying scroll into view action
- waiting 100ms
37 × waiting for element to be stable
- element is not visible
- retrying scroll into view action
- waiting 500ms
at oss/poms/grid/index.ts:71
69 | .locator("div")
70 | .last()
> 71 | .scrollIntoViewIfNeeded({ timeout: Duration.Seconds(20) });
| ^
72 | }
73 |
74 | async scrollTop() {
at GridPom.scrollBottom (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/grid/index.ts:71:8)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/grid-tagging.spec.ts:52:14
|
[chromium] › src/oss/specs/groups/nested-dynamic-groups.spec.ts:121:1 › dynamic groups of groups works:
e2e-pw/src/oss/poms/modal/modal-sidebar.ts#L92
2) [chromium] › src/oss/specs/groups/nested-dynamic-groups.spec.ts:121:1 › dynamic groups of groups works
TimeoutError: page.waitForFunction: Timeout 5000ms exceeded.
at oss/poms/modal/modal-sidebar.ts:92
90 |
91 | async waitUntilSidebarEntryTextEquals(key: string, value: string) {
> 92 | return this.modalSidebarPom.page.waitForFunction(
| ^
93 | ({ key_, value_ }: { key_: string; value_: string }) => {
94 | return (
95 | document.querySelector(`[data-cy='sidebar-entry-${key_}']`)
at SidebarAsserter.waitUntilSidebarEntryTextEquals (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/modal/modal-sidebar.ts:92:38)
at map (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/modal/modal-sidebar.ts:109:14)
at SidebarAsserter.waitUntilSidebarEntryTextEqualsMultiple (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/modal/modal-sidebar.ts:108:31)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/groups/nested-dynamic-groups.spec.ts:165:30
|
[chromium] › src/oss/specs/groups/nested-dynamic-groups.spec.ts:121:1 › dynamic groups of groups works:
e2e-pw/src/oss/poms/modal/modal-sidebar.ts#L92
2) [chromium] › src/oss/specs/groups/nested-dynamic-groups.spec.ts:121:1 › dynamic groups of groups works
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
TimeoutError: page.waitForFunction: Timeout 5000ms exceeded.
at oss/poms/modal/modal-sidebar.ts:92
90 |
91 | async waitUntilSidebarEntryTextEquals(key: string, value: string) {
> 92 | return this.modalSidebarPom.page.waitForFunction(
| ^
93 | ({ key_, value_ }: { key_: string; value_: string }) => {
94 | return (
95 | document.querySelector(`[data-cy='sidebar-entry-${key_}']`)
at SidebarAsserter.waitUntilSidebarEntryTextEquals (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/modal/modal-sidebar.ts:92:38)
at map (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/modal/modal-sidebar.ts:109:14)
at SidebarAsserter.waitUntilSidebarEntryTextEqualsMultiple (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/modal/modal-sidebar.ts:108:31)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/groups/nested-dynamic-groups.spec.ts:165:30
|
[chromium] › src/oss/specs/smoke-tests/quickstart.spec.ts:46:3 › quickstart › smoke:
e2e-pw/src/oss/specs/smoke-tests/quickstart.spec.ts#L1
3) [chromium] › src/oss/specs/smoke-tests/quickstart.spec.ts:46:3 › quickstart › smoke ───────────
Test timeout of 60000ms exceeded.
|
[chromium] › src/oss/specs/smoke-tests/quickstart.spec.ts:46:3 › quickstart › smoke:
e2e-pw/src/shared/event-utils/index.ts#L16
3) [chromium] › src/oss/specs/smoke-tests/quickstart.spec.ts:46:3 › quickstart › smoke ───────────
Error: page.evaluate: Execution context was destroyed, most likely because of a navigation.
at shared/event-utils/index.ts:16
14 |
15 | // note: cannot directly pass function to `evaluate`, which is why we expose it to the `window` object first
> 16 | return this.page.evaluate(
| ^
17 | ({ eventName_, exposedFunctionName_ }) =>
18 | new Promise<void>((resolve) => {
19 | const cb = (e: CustomEvent) => {
at EventUtils.getEventReceivedPromiseForPredicate (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/shared/event-utils/index.ts:16:22)
at UrlPom.pageChange (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/url.ts:40:23)
at UrlPom.back (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/url.ts:47:16)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/smoke-tests/quickstart.spec.ts:65:20
|
all-tests
Process completed with exit code 1.
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L28
'panelLabel' is assigned a value but never used. Allowed unused vars must match /^_|React/u
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L35
'handlePanelStateChange' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L36
'handlePanelStatePathChange' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L37
'panelSchema' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L38
'data' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L39
'onLoadError' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L41
'pending' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L53
React Hook useEffect has missing dependencies: 'panelId', 'panelName', 'props.onUnLoad', 'setPanelCloseEffect', 'trackEvent', and 'triggerPanelEvent'. Either include them or remove the dependency array
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L126
React Hook useEffect has a missing dependency: 'dimensions'. Either include it or remove the dependency array
|
lint / eslint:
app/packages/operators/src/built-in-operators.ts#L820
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
test / test-python (ubuntu-latest-m, 3.11)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test / test-python (ubuntu-latest-m, 3.10)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test / test-python (ubuntu-latest-m, 3.9)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
e2e / test-e2e
Unexpected input(s) 'working-directory', valid inputs are ['path', 'key', 'restore-keys', 'upload-chunk-size', 'enableCrossOsArchive', 'fail-on-cache-miss', 'lookup-only', 'save-always']
|
e2e / test-e2e:
e2e-pw/src/oss/specs/regression-tests/media-field.spec.ts#L85
Unexpected use of the `.skip()` annotation
|
e2e / test-e2e
Unexpected input(s) 'working-directory', valid inputs are ['path', 'key', 'restore-keys', 'upload-chunk-size', 'enableCrossOsArchive', 'fail-on-cache-miss', 'lookup-only', 'save-always']
|
e2e / test-e2e
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/smoke-tests/field-visibility.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/smoke-tests/field-visibility.spec.ts took 1.5m
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/smoke-tests/quickstart-groups.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/smoke-tests/quickstart-groups.spec.ts took 39.1s
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/groups/sparse-groups.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/groups/sparse-groups.spec.ts took 36.3s
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/smoke-tests/saved-views.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/smoke-tests/saved-views.spec.ts took 31.3s
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/sidebar/sidebar.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/sidebar/sidebar.spec.ts took 24.1s
|
🎭 Playwright Run Summary
3 flaky
[chromium] › src/oss/specs/grid-tagging.spec.ts:48:1 › grid tagging ────────────────────────────
[chromium] › src/oss/specs/groups/nested-dynamic-groups.spec.ts:121:1 › dynamic groups of groups works
[chromium] › src/oss/specs/smoke-tests/quickstart.spec.ts:46:3 › quickstart › smoke ────────────
2 skipped
97 passed (9.4m)
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
dist
|
19.9 MB |
|
playwright-report
|
36.8 MB |
|