add default labels visibility in dataset app config + selective labels rendering optimization #7262
pr.yml
on: pull_request
modified-files
51s
teams
0s
Matrix: test / test-python
build
/
changes
29s
build
/
build
2m 16s
e2e
/
test-e2e
19m 58s
lint
/
eslint
48s
test
/
test-app
1m 34s
all-tests
0s
Annotations
11 errors, 20 warnings, and 1 notice
[chromium] › src/oss/specs/overlays/detection-mask.spec.ts:110:3 › detection-mask › should load all masks fine:
e2e-pw/src/oss/specs/overlays/detection-mask.spec.ts#L105
1) [chromium] › src/oss/specs/overlays/detection-mask.spec.ts:110:3 › detection-mask › should load all masks fine
Test timeout of 60000ms exceeded while running "beforeEach" hook.
103 | });
104 |
> 105 | test.beforeEach(async ({ page, fiftyoneLoader }) => {
| ^
106 | await fiftyoneLoader.waitUntilGridVisible(page, datasetName);
107 | });
108 |
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/overlays/detection-mask.spec.ts:105:6
|
[chromium] › src/oss/specs/overlays/detection-mask.spec.ts:110:3 › detection-mask › should load all masks fine:
e2e-pw/src/oss/fixtures/loader.ts#L120
1) [chromium] › src/oss/specs/overlays/detection-mask.spec.ts:110:3 › detection-mask › should load all masks fine
Error: page.reload: Target page, context or browser has been closed
at oss/fixtures/loader.ts:120
118 | ctx.clearCookies();
119 | ctx.clearPermissions();
> 120 | await page.reload({ waitUntil: "domcontentloaded" });
| ^
121 | await this.waitUntilGridVisible(page, datasetName, options, true);
122 | }
123 | }
at OssLoader.waitUntilGridVisible (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/fixtures/loader.ts:120:20)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/overlays/detection-mask.spec.ts:106:3
|
[chromium] › src/oss/specs/overlays/detection-mask.spec.ts:110:3 › detection-mask › should load all masks fine:
e2e-pw/src/oss/fixtures/loader.ts#L118
1) [chromium] › src/oss/specs/overlays/detection-mask.spec.ts:110:3 › detection-mask › should load all masks fine
Error: browserContext.clearCookies: Test timeout of 60000ms exceeded.
at oss/fixtures/loader.ts:118
116 | } else {
117 | const ctx = page.context();
> 118 | ctx.clearCookies();
| ^
119 | ctx.clearPermissions();
120 | await page.reload({ waitUntil: "domcontentloaded" });
121 | await this.waitUntilGridVisible(page, datasetName, options, true);
at OssLoader.waitUntilGridVisible (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/fixtures/loader.ts:118:13)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/overlays/detection-mask.spec.ts:106:3
|
[chromium] › src/oss/specs/overlays/detection-mask.spec.ts:110:3 › detection-mask › should load all masks fine:
e2e-pw/src/oss/fixtures/loader.ts#L129
1) [chromium] › src/oss/specs/overlays/detection-mask.spec.ts:110:3 › detection-mask › should load all masks fine
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
TimeoutError: page.waitForFunction: Timeout 10000ms exceeded.
at oss/fixtures/loader.ts:129
127 | }
128 |
> 129 | await page.waitForFunction(
| ^
130 | () => {
131 | if (document.querySelector(`[data-cy=looker-error-info]`)) {
132 | return true;
at OssLoader.waitUntilGridVisible (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/fixtures/loader.ts:129:16)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/overlays/detection-mask.spec.ts:106:3
|
[chromium] › src/oss/specs/overlays/detection-mask.spec.ts:110:3 › detection-mask › should load all masks fine:
e2e-pw/src/oss/fixtures/loader.ts#L129
1) [chromium] › src/oss/specs/overlays/detection-mask.spec.ts:110:3 › detection-mask › should load all masks fine
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
TimeoutError: page.waitForFunction: Timeout 10000ms exceeded.
at oss/fixtures/loader.ts:129
127 | }
128 |
> 129 | await page.waitForFunction(
| ^
130 | () => {
131 | if (document.querySelector(`[data-cy=looker-error-info]`)) {
132 | return true;
at OssLoader.waitUntilGridVisible (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/fixtures/loader.ts:129:16)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/overlays/detection-mask.spec.ts:106:3
|
[chromium] › src/oss/specs/overlays/detection-mask.spec.ts:110:3 › detection-mask › should load all masks fine:
e2e-pw/src/oss/fixtures/loader.ts#L129
1) [chromium] › src/oss/specs/overlays/detection-mask.spec.ts:110:3 › detection-mask › should load all masks fine
Retry #3 ───────────────────────────────────────────────────────────────────────────────────────
TimeoutError: page.waitForFunction: Timeout 10000ms exceeded.
at oss/fixtures/loader.ts:129
127 | }
128 |
> 129 | await page.waitForFunction(
| ^
130 | () => {
131 | if (document.querySelector(`[data-cy=looker-error-info]`)) {
132 | return true;
at OssLoader.waitUntilGridVisible (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/fixtures/loader.ts:129:16)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/overlays/detection-mask.spec.ts:106:3
|
[chromium] › src/oss/specs/smoke-tests/quickstart.spec.ts:46:3 › quickstart › smoke:
e2e-pw/src/oss/specs/smoke-tests/quickstart.spec.ts#L1
2) [chromium] › src/oss/specs/smoke-tests/quickstart.spec.ts:46:3 › quickstart › smoke ───────────
Test timeout of 60000ms exceeded.
|
[chromium] › src/oss/specs/smoke-tests/quickstart.spec.ts:46:3 › quickstart › smoke:
e2e-pw/src/shared/event-utils/index.ts#L16
2) [chromium] › src/oss/specs/smoke-tests/quickstart.spec.ts:46:3 › quickstart › smoke ───────────
Error: page.evaluate: Execution context was destroyed, most likely because of a navigation.
at shared/event-utils/index.ts:16
14 |
15 | // note: cannot directly pass function to `evaluate`, which is why we expose it to the `window` object first
> 16 | return this.page.evaluate(
| ^
17 | ({ eventName_, exposedFunctionName_ }) =>
18 | new Promise<void>((resolve) => {
19 | const cb = (e: CustomEvent) => {
at EventUtils.getEventReceivedPromiseForPredicate (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/shared/event-utils/index.ts:16:22)
at UrlPom.pageChange (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/url.ts:40:23)
at UrlPom.back (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/url.ts:47:16)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/smoke-tests/quickstart.spec.ts:65:20
|
[chromium] › src/oss/specs/smoke-tests/quickstart.spec.ts:46:3 › quickstart › smoke:
e2e-pw/src/oss/specs/smoke-tests/quickstart.spec.ts#L36
2) [chromium] › src/oss/specs/smoke-tests/quickstart.spec.ts:46:3 › quickstart › smoke ───────────
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Test timeout of 60000ms exceeded while running "beforeEach" hook.
34 | });
35 |
> 36 | test.beforeEach(async ({ page, fiftyoneLoader }) => {
| ^
37 | await fiftyoneLoader.waitUntilGridVisible(page, datasetName);
38 | });
39 |
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/smoke-tests/quickstart.spec.ts:36:6
|
[chromium] › src/oss/specs/smoke-tests/quickstart.spec.ts:46:3 › quickstart › smoke:
e2e-pw/src/oss/fixtures/loader.ts#L69
2) [chromium] › src/oss/specs/smoke-tests/quickstart.spec.ts:46:3 › quickstart › smoke ───────────
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: locator.click: Test timeout of 60000ms exceeded.
Call log:
- waiting for getByTestId('selector-result-smoke-quickstart-jtxuaw7')
at oss/fixtures/loader.ts:69
67 |
68 | if (datasetName) {
> 69 | await page.getByTestId(`selector-result-${datasetName}`).click();
| ^
70 | } else {
71 | const firstSelectorResult = page.locator(
72 | "[data-cy=selector-results-container] > div"
at forceDatasetFromSelector (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/fixtures/loader.ts:69:66)
at OssLoader.waitUntilGridVisible (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/fixtures/loader.ts:91:7)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/smoke-tests/quickstart.spec.ts:37:3
|
all-tests
Process completed with exit code 1.
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L28
'panelLabel' is assigned a value but never used. Allowed unused vars must match /^_|React/u
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L35
'handlePanelStateChange' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L36
'handlePanelStatePathChange' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L37
'panelSchema' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L38
'data' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L39
'onLoadError' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L41
'pending' is never reassigned. Use 'const' instead
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L53
React Hook useEffect has missing dependencies: 'panelId', 'panelName', 'props.onUnLoad', 'setPanelCloseEffect', 'trackEvent', and 'triggerPanelEvent'. Either include them or remove the dependency array
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L126
React Hook useEffect has a missing dependency: 'dimensions'. Either include it or remove the dependency array
|
lint / eslint:
app/packages/operators/src/built-in-operators.ts#L820
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
test / test-python (ubuntu-latest-m, 3.10)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test / test-python (ubuntu-latest-m, 3.9)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test / test-python (ubuntu-latest-m, 3.11)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
e2e / test-e2e
Unexpected input(s) 'working-directory', valid inputs are ['path', 'key', 'restore-keys', 'upload-chunk-size', 'enableCrossOsArchive', 'fail-on-cache-miss', 'lookup-only', 'save-always']
|
e2e / test-e2e
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/smoke-tests/field-visibility.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/smoke-tests/field-visibility.spec.ts took 1.5m
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/smoke-tests/quickstart-groups.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/smoke-tests/quickstart-groups.spec.ts took 39.7s
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/groups/sparse-groups.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/groups/sparse-groups.spec.ts took 35.4s
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/sidebar/sidebar.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/sidebar/sidebar.spec.ts took 24.2s
|
Slow Test:
e2e-pw/[chromium] › src/oss/specs/operators/prompt.spec.ts#L1
e2e-pw/[chromium] › src/oss/specs/operators/prompt.spec.ts took 21.8s
|
🎭 Playwright Run Summary
2 failed
[chromium] › src/oss/specs/overlays/detection-mask.spec.ts:110:3 › detection-mask › should load all masks fine
[chromium] › src/oss/specs/smoke-tests/quickstart.spec.ts:46:3 › quickstart › smoke ────────────
3 flaky
[chromium] › src/oss/specs/grid-tagging.spec.ts:48:1 › grid tagging ────────────────────────────
[chromium] › src/oss/specs/smoke-tests/saved-views.spec.ts:170:3 › saved views › deleting a saved view clears the URL view parameter and view selection
[chromium] › src/oss/specs/smoke-tests/tagger.spec.ts:48:3 › tag › sample tag and label tag loads correct aggregation number on default view
2 skipped
3 did not run
92 passed (14.1m)
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
dist
|
19.9 MB |
|
playwright-report
|
95.8 MB |
|