(BKR-1656) Fixes for cat and file_exist? on PSWindows #1654
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are needed in order to have the same output when these methods are used on different platforms. The implementation for unix is slightly different and had a different return values.
Having the same return values for both unix and windows implementation will reduce the need to check which os you're running on when writing beaker tests.
file_exist? had a different output compared to the unix implementation (which returns bool). It actually returned the position of where it found the the match.
cat had different output due to the fact that
execute
does not wrap the output in anResponse
object, butexec
does.