Use the new scheme for agent versions >= 6.28 and < 7 #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1749 +/- ##
==========================================
+ Coverage 74.85% 75.04% +0.18%
==========================================
Files 82 82
Lines 4871 4872 +1
==========================================
+ Hits 3646 3656 +10
+ Misses 1225 1216 -9
Continue to review full report at Codecov.
|
joshcooper
force-pushed
the
macos_arch_part2
branch
2 times, most recently
from
eb7ed13 to
afa2de6
Compare
joshcooper
changed the title
Commit 0008b7f incorrectly returned the old scheme for agent version 6.28.0, since 6.18 < 7.18. It also incorrectly returned the new scheme if the puppet_agent_version was omitted. It now returns the new scheme for versions in the range >= 6.18 to < 7.0, and returns the old scheme if the version is omitted.
joshcooper
force-pushed
the
macos_arch_part2
branch
from
afa2de6 to
3030c63
Compare
nmburgan
approved these changes
Jul 28, 2022
bastelfreak
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 0008b7f incorrectly returned the old
scheme for agent version 6.28.0, since 6.18 < 7.18. It also incorrectly returned
the new scheme if the puppet_agent_version was omitted.
It now returns the new scheme for versions in the range >= 6.18 to < 7.0, and
returns the old scheme if the version is omitted.