get_facts.sh: Drop support for Puppet 7 #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Puppet 7 and Puppet 8 ship the same facter versions. It doesn't make sense to generate facts for Puppet 7 and then overwrite them with a factset from Puppet 8.
jstraw
approved these changes
May 15, 2024
yakatz
pushed a commit
to yakatz/facterdb
that referenced
this pull request
May 15, 2024
This will allow scripts for different operating systems to be separated and still use the same versions This also helps keep track of what facter versions are being used with each version of Puppet Agent. Tested on RHEL 9, Fedora 38, Ubuntu 20.04, Windows 10, Windows Server 2019 Inspired by voxpupuli#330
yakatz
pushed a commit
to yakatz/facterdb
that referenced
this pull request
May 15, 2024
This will allow scripts for different operating systems to be separated and still use the same versions This also helps keep track of what facter versions are being used with each version of Puppet Agent. Tested on RHEL 9, Fedora 38, Ubuntu 20.04, Windows 10, Windows Server 2019 Inspired by voxpupuli#330
yakatz
added a commit
to yakatz/facterdb
that referenced
this pull request
May 15, 2024
This will allow scripts for different operating systems to be separated and still use the same versions This also helps keep track of what facter versions are being used with each version of Puppet Agent. Tested on RHEL 9, Fedora 38, Ubuntu 20.04, Windows 10, Windows Server 2019 Inspired by voxpupuli#330
yakatz
added a commit
to yakatz/facterdb
that referenced
this pull request
May 15, 2024
This will allow scripts for different operating systems to be separated and still use the same versions This also helps keep track of what facter versions are being used with each version of Puppet Agent. Tested on RHEL 9, Fedora 38, Ubuntu 20.04, Windows 10, Windows Server 2019 Inspired by voxpupuli#330
yakatz
added a commit
to yakatz/facterdb
that referenced
this pull request
May 15, 2024
This will allow scripts for different operating systems to be separated and still use the same versions This also helps keep track of what facter versions are being used with each version of Puppet Agent. Tested on RHEL 9, Fedora 39, Ubuntu 20.04, Windows 10, Windows Server 2019 Inspired by voxpupuli#330
yakatz
added a commit
to yakatz/facterdb
that referenced
this pull request
May 15, 2024
This will allow scripts for different operating systems to be separated and still use the same versions This also helps keep track of what facter versions are being used with each version of Puppet Agent. Tested on RHEL 9, Ubuntu 20.04, Windows 10, Windows Server 2019, Archlinux Inspired by voxpupuli#330
yakatz
added a commit
to yakatz/facterdb
that referenced
this pull request
May 15, 2024
This will allow scripts for different operating systems to be separated and still use the same versions This also helps keep track of what facter versions are being used with each version of Puppet Agent. Tested on RHEL 9, openSUSE 15.4, Ubuntu 20.04, Windows 10, Windows Server 2019 Inspired by voxpupuli#330
yakatz
added a commit
to yakatz/facterdb
that referenced
this pull request
May 15, 2024
This will allow scripts for different operating systems to be separated and still use the same versions This also helps keep track of what facter versions are being used with each version of Puppet Agent. Tested on RHEL 9, openSUSE 15.4, Ubuntu 20.04, Windows 10, Windows Server 2019 Inspired by voxpupuli#330
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Puppet 7 and Puppet 8 ship the same facter versions. It doesn't make sense to generate facts for Puppet 7 and then overwrite them with a factset from Puppet 8.
You could argue that this isn't a breaking change. But the next release is a major one anyways.