Prepare release of 2.5.1

[RST-J]

I've prepared a milestone for the next minor release 2.5.1 as requested in #227.

If think these should be added before we release:

• Only add violating properties to error message for strict validation #230 fixed error message for strict validation
• Updated to addressable 2.3.7 #226 updated addressable dependency
• Made sure we really do update the common test suite before test runs #224 ensured update for common test suite
• Added Ruby 2.2 to the build matrix #223 adding Ruby 2.2. to the Travis build
• Renamed variable in oneOf to avoid name clash #221 renamed variable
• Issue with Fixnum and Float in enum #219 issue with integer and fload equality

Anything more?

[iainbeeston]

Isn't #206 too large a change for a patch release? (I believe it was slated for version 3?) I don't have a problem with the idea of releasing that as 2.6 though

[RST-J]

I can't see a clear tendency in the discussion of #206. But I agree, if we decide to take this in for the next release, we should have a minor release.
What do you think @pd @hoxworth?

[hoxworth]

I'd personally prefer #206 to be a major release, considering it will break
backwards compatibility with users that presently use the JSON parsers that
are currently supported.

On Sun, Feb 8, 2015 at 11:55 AM, Jonas Peschla [email protected]
wrote:

I can't see a clear tendency in the discussion of #206
#206. But I agree,
if we decide to take this in for the next release, we should have a minor
release.
What do you think @pd https://github.com/pd @hoxworth
https://github.com/hoxworth?

—
Reply to this email directly or view it on GitHub
#228 (comment)
.

[RST-J]

That makes sense, agreed.

[iainbeeston]

If anyone can help review those and get them merged, that would be great (reminder to self - I need to review #219 !)

[iainbeeston]

Oh, and I suggest we also try to fix #220 for the release (no pull request yet...)

[RST-J]

@pd, @hoxworth got someone of you two time to do the remaining reviews so we can release in the near future?

[inglesp]

I've reviewed all of these, and I think they're all fine, with just one comment. Is there anything else I can do to help get this ticket closed?

[iainbeeston]

@pd ? @hoxworth? Sorry to bother you but we really need some members of the core team to review before we can merge those changes and make the release

[hoxworth]

These all look good. Sorry I haven't been around, other things keeping my attention. I'll +1 these individually momentarily.

For the future, never be afraid to push minor / patch releases when there is code ready. Even if we're waiting for +1's on other pull requests, as long as they don't block one another, it would be better to get fixes / better code available for general availability sooner rather than later in a big chunk.

[iainbeeston]

Great, thanks for taking a look @hoxworth. I'll remember that next time.

@RST-J Do you want to make the release or shall I?

[RST-J]

@iainbeeston go ahead, I'm busy today and could only release later in the evening or tomorrow.

[iainbeeston]

I've just made the release, get it while it's hot.

[inglesp]

Thanks everyone!