Fix list:true
when referencing a cached schema
#107
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
list: true
option, if the schema has already been cached inValidator.schemas
, json-schema would not wrap the schema in{ "type": "array", "items": ... }
as expected.Test included to demonstrate the failure; the fix was to use
fake_uri
as is done elsewhere to generate an identifier for the wrapper schema. I didn't add a test to thetest_jsonschema_draft3
file, as this appears to be an identical code path, so the duplication shouldn't be necessary AFAICT.