Addressable gem dependency fix #301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 28, 2016 16:13
…on-schema will not work with the latest version of the addressable gem.
iainbeeston
pushed a commit
to iainbeeston/json-schema
that referenced
this pull request
Feb 26, 2016
I've had to change one of the specs because of this. It seems that addressable now raises an error if you parse a uri that looks like a json text, which was one of our test cases. This fixes and supersedes voxpupuli#301
iainbeeston
pushed a commit
to iainbeeston/json-schema
that referenced
this pull request
Feb 26, 2016
I've had to change one of the specs because of this. It seems that addressable now raises an error if you parse a uri that looks like a json text, which was one of our test cases. This fixes and supersedes voxpupuli#301
iainbeeston
pushed a commit
to iainbeeston/json-schema
that referenced
this pull request
Sep 29, 2016
I've had to change one of the specs because of this. It seems that addressable now raises an error if you parse a uri that looks like a json text, which was one of our test cases. This fixes and supersedes voxpupuli#301
iainbeeston
added a commit
that referenced
this pull request
Sep 29, 2016
I've had to change one of the specs because of this. It seems that addressable now raises an error if you parse a uri that looks like a json text, which was one of our test cases. This fixes and supersedes #301
|
I'm going to close this now #312 has been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new version of addressable gem is out (2.4.x). Without this fix, json-schema will not work with the latest version of the addressable gem.