Updated example of extending an existing schema #315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -15,7 +15,6 @@ end | |||
| Rake::TestTask.new do |t| | |||
| t.libs << "." | |||
| t.warning = true | |||
| t.verbose = true | |||
There was a problem hiding this comment.
Can we please not change unrelated things in this pull request? If you think the test output is too noisy please open a separate pull request for that, where we can discuss the pros and cons
There was a problem hiding this comment.
That change fixes the CI build failure that I ran into the when I first submitted this PR. It looks like the verbose flag isn't supported by jruby or Rubinius.
There was a problem hiding this comment.
But isn't it working on master?
|
Closing this, as I already merged the same change in #335 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The README gives an example of how to validate an extended schema, but it looks like the code is out of date. This fixes it.